mirror of https://git.ffmpeg.org/ffmpeg.git
2fae000994
libswscale/vscale.c makes extensive use of function pointers and in doing so it converts these function pointers to and from a pointer to void. Yet this is actually against the C standard: C90 only guarantees that one can convert a pointer to any incomplete type or object type to void* and back with the result comparing equal to the original which makes pointers to void generic pointers to incomplete or object type. Yet C90 lacks a generic function pointer type. C99 additionally guarantees that a pointer to a function of one type may be converted to a pointer to a function of another type with the result and the original comparing equal when converting back. This makes any function pointer type a generic function pointer type. Yet even this does not make pointers to void generic function pointers. Both GCC and Clang emit warnings for this when in pedantic mode. This commit fixes this by using a union that can hold one member of any of the required function pointer types to store the function pointer. This works even for C90. Reviewed-by: Michael Niedermayer <michael@niedermayer.cc> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> |
||
|---|---|---|
| .. | ||
| aarch64 | ||
| arm | ||
| ppc | ||
| tests | ||
| x86 | ||
| Makefile | ||
| alphablend.c | ||
| bayer_template.c | ||
| gamma.c | ||
| hscale.c | ||
| hscale_fast_bilinear.c | ||
| input.c | ||
| libswscale.v | ||
| log2_tab.c | ||
| options.c | ||
| output.c | ||
| rgb2rgb.c | ||
| rgb2rgb.h | ||
| rgb2rgb_template.c | ||
| slice.c | ||
| swscale.c | ||
| swscale.h | ||
| swscale_internal.h | ||
| swscale_unscaled.c | ||
| swscaleres.rc | ||
| utils.c | ||
| version.h | ||
| vscale.c | ||
| yuv2rgb.c | ||