b0350c1c30
ra144enc: fix end-of-stream handling
...
Use CODEC_CAP_DELAY and CODEC_CAP_SMALL_LAST_FRAME to properly pad and flush
the encoder at the end of encoding. This is needed in order to have all input
samples decoded.
2012-03-04 01:14:53 -05:00
29e2c85310
nellymoserenc: zero any leftover packet bytes
...
fixes writing of uninitialized packet data
2012-03-04 01:14:52 -05:00
6c7a01621c
nellymoserenc: use proper MDCT overlap delay
2012-03-04 01:14:52 -05:00
3e9cd8b4b0
qpeg: Use bytestream2 functions to prevent buffer overreads.
...
Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
2012-03-03 20:40:00 -08:00
b4188f0d46
vp8: convert simple loopfilter x86 assembly to use named arguments.
2012-03-03 20:40:00 -08:00
8476ca3b4e
vp8: convert idct x86 assembly to use named arguments.
2012-03-03 20:40:00 -08:00
21ffc78fd7
vp8: convert mc x86 assembly to use named arguments.
2012-03-03 20:40:00 -08:00
28170f1a39
vp8: convert loopfilter x86 assembly to use cpuflags().
2012-03-03 20:40:00 -08:00
e25be47154
vp8: convert idct/mc x86 assembly to use cpuflags().
2012-03-03 20:39:59 -08:00
51ddf35c90
wmaenc: fix m/s stereo encoding for the first frame
...
We need to set ms_stereo in encode_init() in order to avoid incorrectly
encoding the first frame as non-m/s while flagging it as m/s. Fixes an
uncomfortable pop in the left channel at the start of playback.
CC:libav-stable@libav.org
2012-03-03 18:20:10 -05:00
8ed7488ea3
wmaenc: return s->block_align instead of recalculating it
2012-03-03 18:20:10 -05:00
5d652e063b
wmaenc: check final frame size against output packet size
...
Currently we have an assert() that prevents the frame from being too large,
but it is more user-friendly to give an error message instead of aborting on
assert(). This condition is quite unlikely due to the minimum bit rate check
in encode_init(), but it is still worth having.
2012-03-03 18:20:10 -05:00
dfc4fdedf8
wmaenc: require a large enough output buffer to prevent overwrites
...
The maximum theoretical frame size is around 17000 bytes. Although in
practice it will generally be much smaller, we require a larger buffer
just to be safe.
CC: libav-stable@libav.org
2012-03-03 18:20:10 -05:00
1ec075cfec
wmaenc: limit allowed sample rate to 48kHz
...
ff_wma_init() allows up to 50kHz, but this generates an exponent band
size table that requires 65 bands. The code assumes 25 bands in many
places, and using sample rates higher than 48kHz will lead to buffer
overwrites.
CC:libav-stable@libav.org
2012-03-03 18:20:10 -05:00
c2b8dea182
wmaenc: limit block_align to MAX_CODED_SUPERFRAME_SIZE
...
This is near the theoretical limit for wma frame size and is the most that
our decoder can handle. Allowing higher bit rates will just end up padding
each frame with empty bytes.
Fixes invalid writes for avconv when using very high bit rates.
CC:libav-stable@libav.org
2012-03-03 18:20:09 -05:00
0b8b7db01b
mpegaudio_parser: do not ignore information from the first parsed frame
...
Update some demuxing and seeking fate tests.
2012-03-03 17:03:26 -05:00
6776a8f189
mpegaudio_parser: be less picky about the start position
...
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-03-03 17:03:26 -05:00
5602a464c9
avcodec: add a Vorbis parser to get packet duration
...
This also allows for removing some of the Vorbis-related hacks.
2012-03-03 16:43:11 -05:00
737ca4482b
vorbisdec: read the previous window flag for long windows
...
When reading sequentially, we are using the actual flag from the previous
frame, but when seeking we do not know what the previous window flag was, so
we need to read it from the bitstream.
2012-03-03 16:43:11 -05:00
7fb6c9225c
lavc: free the output packet when encoding failed or produced no output.
2012-03-03 06:31:41 +01:00
e42e9b0e4d
lavc: preserve avpkt->destruct in ff_alloc_packet().
...
Also, don't bother with saving/restoring data, av_init_packet doesn't
touch it.
2012-03-03 06:31:41 +01:00
c179c9e19d
lavc: clarify the meaning of AVCodecContext.frame_number.
2012-03-03 06:31:41 +01:00
9d87374ec0
amrwb: remove duplicate arguments from extrapolate_isf().
...
Prevents warnings because the dst and src overlap (are the same) in the
memcpy() inside the function.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-03-02 12:50:00 -08:00
154b8bb800
amrwb: error out early if mode is invalid.
...
Prevents using the invalid mode as an index in a static array, which
would generate invalid reads.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-03-02 10:34:50 -08:00
291c9b6285
h264: change underread for 10bit QPEL to overread.
...
This prevents us from reading before the start of the buffer, and thus
prevents crashes resulting from this behaviour. Fixes bug 237.
2012-03-02 10:33:05 -08:00
45549339bc
vp8: disable mmx functions with sse/sse2 counterparts on x86-64.
...
x86-64 is guaranteed to have at least SSE2, therefore the MMX/MMX2
functions will never be used in practice.
2012-03-02 10:32:05 -08:00
bd66f073fe
vp8: change int stride to ptrdiff_t stride.
...
On 64bit platforms with 32bit int, this means we won't have to sign-
extend the integer anymore.
2012-03-02 10:31:50 -08:00
349b7977e4
wma: fix invalid buffer size assumptions causing random overreads.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-03-02 10:31:28 -08:00
9d25f1f619
Windows Media Audio Lossless decoder
...
Decodes 16-bit WMA Lossless encoded files. 24-bit is not supported yet.
Bitstream parser written by Andreas Öman with contributions from
Baptiste Coudurier and Ulion.
Includes a number of bug-fixes from Benjamin Larsson, Michael Niedermayer and
Konstantin Shishkov, shine and polish by Diego Biurrun.
Signed-off-by: Diego Biurrun <diego@biurrun.de>
2012-03-02 19:10:29 +01:00
9243ec4a50
rv10/20: Fix slice overflow with checked bitstream reader.
2012-03-02 09:31:32 -08:00
71db86d53b
h263dec: Disallow width/height changing with frame threads.
...
Fixes CVE-2011-3937
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
2012-03-02 09:31:32 -08:00
2f6528537f
rv10/20: Fix a buffer overread caused by losing track of the remaining buffer size.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-03-02 09:31:32 -08:00
b087ce2bee
g722: Fix the QMF scaling
...
This fixes clipping if the encoder input used the full 16 bit
input range (samples with a magnitude below 16383 worked fine).
The filtered subband samples should be 15 bit maximum, while
the code earlier produced them scaled to 16 bit.
This makes the decoder output have double the magnitude
compared to before.
The spec reference samples doesn't test the QMF at all, which
was why this part slipped past initially.
Signed-off-by: Martin Storsjö <martin@martin.st>
2012-03-02 18:58:19 +02:00
f604eab30a
wavpack: Fix an integer overflow
...
Integer Overflow Checker detected an integer
overflow while FATE was running.
See: http://fate.libav.org/x86_64-linux-ioc/
Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
Signed-off-by: Kostya Shishkov <kostya.shishkov@gmail.com>
2012-03-02 08:26:36 +01:00
1c4717be4f
mjpegdec: use correct variable in av_log invocation
...
libavcodec/mjpegdec.c:1463: warning: format ‘%x’ expects type ‘unsigned int’, but argument 5 has type ‘const uint8_t *’
2012-03-01 23:11:15 +01:00
324deaa268
Replace AVFrame pointer type punning by proper struct member assignments.
2012-03-01 23:11:13 +01:00
47c0ac96aa
Replace AVFrame pointer casts by proper struct member accesses.
2012-03-01 23:11:11 +01:00
562b6c744a
Remove unnecessary AVFrame pointer casts.
2012-03-01 23:11:10 +01:00
2f4b476e04
msmpeg4: Split encoding backend code off from general backend code.
2012-03-01 23:11:09 +01:00
eb727387fd
lavc: shrink encoded video packet size after encoding.
...
Based on a patch by Nicolas George <nicolas.george <at> normalesup.org>
2012-03-01 22:21:35 +01:00
0ce4fe482c
h264: error out on invalid bitdepth.
...
Fixes invalid reads while initializing the dequant tables, which uses
the bit depth to determine the QP table size.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-03-01 12:15:51 -08:00
cc412b7104
aacsbr: use a swap index for the Y matrix rather than copy buffers.
...
Signed-off-by: Alex Converse <alex.converse@gmail.com>
2012-03-01 11:03:00 -08:00
63c9de6469
huffyuv: do not abort on unknown pix_fmt; instead, return an error.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-03-01 10:23:36 -08:00
bd17a40a7e
lcl: return negative error codes on decode_init() errors.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-03-01 07:12:29 -08:00
bdc1220eeb
h263enc: Add an option for outputting info about MBs as side data
...
Signed-off-by: Martin Storsjö <martin@martin.st>
2012-03-01 16:08:31 +02:00
442c1320e7
avpacket: Add a function for shrinking already allocated side data
...
Signed-off-by: Martin Storsjö <martin@martin.st>
2012-03-01 16:08:30 +02:00
5cd1337f5d
nellymoserdec: Saner and faster IMDCT windowing
...
Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
2012-02-29 15:38:35 -08:00
882abda5a2
amrnbdec: check frame size before decoding.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
2012-02-29 14:13:58 -08:00
8a9faf33f2
cscd: use negative error values to indicate decode_init() failures.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-29 14:04:23 -08:00
d1604b3de9
h264: prevent overreads in intra PCM decoding.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-29 13:17:34 -08:00
9b4cd58611
mpegaudiodec: use DSPUtil.butterflies_float().
...
Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
2012-02-29 12:12:50 -08:00
07a180972f
vmnc: return error on decode_init() failure.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-29 11:58:27 -08:00
a45a1ea521
libvorbis: add/update error messages
...
also use AVERROR codes for some return values instead of -1
2012-02-29 14:54:25 -05:00
592c4dbc7e
libvorbis: use AVFifoBuffer for output packet buffer
...
simplifies the code and does less memmove()
2012-02-29 14:54:24 -05:00
1fe7c1be54
libvorbis: remove unneeded e_o_s check
...
vorbis_bitrate_flushpacket() does not return any packets that should not be
output in the bitstream.
2012-02-29 14:54:24 -05:00
94025d8a99
libvorbis: check return values for functions that can return errors
2012-02-29 14:54:24 -05:00
c5063e0348
libvorbis: use float input instead of s16
...
libvorbis takes float input, so we can just deinterleave/reorder the input
as-is instead of also converting.
2012-02-29 14:54:24 -05:00
f15c4281dc
libvorbis: do not flush libvorbis analysis if dsp state was not initialized
...
Fixes a segfault if init() fails before initializing the dsp state
2012-02-29 14:54:23 -05:00
147ff24a0e
libvorbis: use VBR by default, with default quality of 3
2012-02-29 14:54:20 -05:00
182d4f1f38
libvorbis: fix use of minrate/maxrate AVOptions
...
- enable the options for audio encoding
- properly check for user-set maxrate
- use correct calling order in vorbis_encode_setup_managed()
2012-02-29 14:44:15 -05:00
eb35ef2932
libvorbis: cosmetics: renaming/pretty-printing/comments/unused code
2012-02-29 14:44:15 -05:00
4e99501f62
(e)ac3enc: select a default bit rate based on the channel layout
2012-02-29 14:36:00 -05:00
6aeea1dfb2
ac3enc: choose the closest bit rate to the one requested instead of failing
2012-02-29 14:36:00 -05:00
78e9852a2e
rpza: error out on buffer overreads.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-29 11:21:01 -08:00
e54ae60e46
qtrle: return error on decode_init() failure.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-29 11:20:29 -08:00
85b221e4d3
dpxenc: Don't include the libavcodec ident if bitexact mode is enabled
...
This avoids breaking fate every time the lavc version is bumped.
Signed-off-by: Martin Storsjö <martin@martin.st>
2012-02-29 20:08:09 +02:00
12b812d2e5
prores: store and retrieve extended colourspace information
...
Based on the patch by Phil Barrett.
2012-02-29 09:29:02 +01:00
c7084182e8
proresenc: correct edge emulation
...
Signed-off-by: Kostya Shishkov <kostya.shishkov@gmail.com>
2012-02-29 09:28:45 +01:00
235d693286
prores: handle 444 chroma in right order
...
ProRes codes chroma blocks in 444 mode in different order than luma blocks,
so make both decoder and encoder read/write chroma blocks in right order.
Reported by Phil Barrett
2012-02-29 09:28:34 +01:00
23bfcc066d
mpegvideo_enc: add quantizer_noise_shaping private option.
...
Deprecate corresponding AVCodecContext field.
2012-02-29 07:26:24 +01:00
16b7557b79
lavc: deprecate AVCodecContext.inter_threshold.
...
It's unused.
2012-02-29 07:25:44 +01:00
4f07f8196c
lavc: deprecate AVCodecContext.color_table_id.
...
It's currently only used as temporary storage by the mov demuxer. Make
it use a local variable instead.
2012-02-29 07:25:00 +01:00
63efd83ae1
mpegvideo_enc: add chroma/luma_elim_threshold private options.
...
Deprecate corresponding AVCodecContext fields.
2012-02-29 07:23:31 +01:00
af3d804f9f
mpegvideo_enc: add cbp_rd flag to mpv_flags.
...
Deprecate CODEC_FLAG_CBP_RD.
2012-02-29 07:13:58 +01:00
ff71a383ac
mpegvideo_enc: add qp_rd flag to mpv_flags.
...
Deprecate CODEC_FLAG_QP_RD.
2012-02-29 07:12:10 +01:00
a249f0cc23
mpegvideo_enc: add strict_gop flag to mpv_flags.
...
Deprecate CODEC_FLAG2_STRICT_GOP.
2012-02-29 07:11:02 +01:00
ed019b8e5b
lavc: add -mpv_flags to mpegvideo_enc-based encoders.
...
Deprecate CODEC_FLAG2_SKIP_RD in favor of the corresponding mpv_flags
flag.
2012-02-29 07:09:29 +01:00
956fb91e03
aacdec: Support stereo streams that erroneously signal predefined channel configuration 1 (mono).
...
[alex.converse@mgail.com ]
Move code to get_che()
Update for AAC new channel configuration interface
Only set chan_config if output_configure succeeds.
Signed-off-by: Alex Converse <alex.converse@gmail.com>
2012-02-28 21:38:16 -08:00
2564f6e6d4
aacdec: Reshuffle functions so get_che() can call set_default_channel_config() and output_configure().
2012-02-28 21:38:15 -08:00
8bc396fc0e
vp56: error out on invalid stream dimensions.
...
Prevents crashes when playing corrupt vp5/6 streams.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-28 16:41:58 -08:00
bbeb29133b
adpcm: Clip step_index values read from the bitstream at the beginning of each frame.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
2012-02-28 12:11:06 -08:00
cfac648e6a
doxygen: Remove documentation for non-existing parameters; misc small fixes.
2012-02-28 20:48:43 +01:00
fc9bc08dca
Indeo3: fix crashes on corrupt bitstreams.
...
Splits at borders of cells are invalid, since it leaves one of the
cells with a width/height of zero. Also, propagate errors on buffer
allocation failures, so we don't continue decoding (which crashes).
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-28 10:34:35 -08:00
bd7a647c0d
msmpeg4: Replace forward declaration by proper #include.
2012-02-28 15:36:47 +01:00
5e239c7f9e
aacdec: Remove erroneous reference to global gain from the out of bounds scalefactor error message.
2012-02-27 17:59:47 -08:00
d10319d87f
avcodec_default_reget_buffer(): fix compilation in DEBUG mode
2012-02-27 20:58:43 +01:00
b0c4f04338
h264: fix mmxext chroma deblock to use correct TC values.
2012-02-27 09:38:44 -08:00
b1edfce08a
lavc: reorder AVCodecContext fields.
...
Put related fields together, move the important ones closer to the
beginning, try to eliminate holes.
2012-02-27 07:09:43 +01:00
1d428004c6
lavc: reorder AVFrame fields.
...
Put related fields together, move the important ones closer to the
beginning, try to eliminate holes.
2012-02-27 07:07:25 +01:00
790a367d9e
Fix parser not to clobber has_b_frames when extradata is set.
...
Because in contrast to the decoder, the parser does not setup low_delay.
The code in parse_nal_units would always end up setting has_b_frames
to "1", except when stream is explicitly marked as low delay.
Since the parser itself would create 'extradata', simply reopening
the parser would cause this.
This happens for instance in estimate_timings_from_pts(), which causes the
parser to be reopened on the same stream.
This fixes Libav #22 and FFmpeg (trac) #360
CC: libav-stable@libav.org
Based on a patch by Reimar Döffinger <Reimar.Doeffinger@gmx.de>
(commit 31ac0ac29b
2012-02-26 15:50:59 +01:00
42459c6abb
cdxl: bit line plane arrangement support
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-26 00:04:32 -05:00
cf6914e27f
cdxl: remove early check for bpp
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-26 00:04:32 -05:00
126daeb550
cdxl: set pix_fmt PAL8 only if palette is available
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-26 00:04:32 -05:00
0a9efe4c6e
mlp_parser: fix the channel mask value used for the top surround channel
...
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-25 17:24:43 -05:00
be8d812c96
vorbisenc: check all allocations for failure
2012-02-25 11:49:43 -05:00
f7a2e12f2a
roqaudioenc: return AVERROR codes instead of -1
2012-02-25 11:49:43 -05:00
3fa9a999c1
roqaudioenc: set correct bit rate
2012-02-25 11:49:43 -05:00
cf57c78b77
roqaudioenc: use AVCodecContext.frame_size correctly.
...
It is not allowed to change mid-stream like it does currently. Instead we need
to buffer the first 8 frames before returning them as a single packet, then
only return single frame packets after that.
2012-02-25 11:49:43 -05:00
56279f1d61
roqaudioenc: remove unneeded sample_fmt check
2012-02-25 11:49:43 -05:00
4b7f8838e8
ra144enc: use int16_t* for input samples rather than void*
2012-02-25 11:49:43 -05:00
03359ebcf9
ra144enc: set AVCodecContext.coded_frame
2012-02-25 11:49:43 -05:00
a65f7c96fc
ra144enc: remove unneeded sample_fmt check
2012-02-25 11:49:42 -05:00
928672f1f1
nellymoserenc: set AVCodecContext.coded_frame
2012-02-25 11:49:42 -05:00
370b44cda2
nellymoserenc: improve error checking in encode_init()
2012-02-25 11:49:42 -05:00
333506c33f
nellymoserenc: return AVERROR codes instead of -1
2012-02-25 11:49:42 -05:00
6f600ab354
libvorbis: improve error checking in oggvorbis_encode_init()
2012-02-25 11:49:42 -05:00
be60eec668
mpegaudioenc: return AVERROR codes instead of -1
2012-02-25 11:49:42 -05:00
7a8cbb39f6
libfaac: improve error checking and handling in Faac_encode_init()
2012-02-25 11:49:42 -05:00
a8bdf2405c
check for coded_frame allocation failure in several audio encoders
2012-02-25 11:49:41 -05:00
255ad8881d
audio encoders: do not set coded_frame->key_frame.
...
it is already set in avcodec_alloc_frame()
2012-02-25 11:49:41 -05:00
8e2555d3b1
g722enc: check for trellis data allocation error
2012-02-25 11:49:41 -05:00
ca300d938b
libspeexenc: export encoder delay through AVCodecContext.delay
2012-02-25 11:49:41 -05:00
7600e5c5aa
avcodec: document the use of AVCodecContext.delay for audio encoders
2012-02-25 11:49:41 -05:00
6c4c27adb6
kgv1: release reference picture on size change.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-25 07:53:44 -08:00
03ca0a5b30
lavc: merge two if()s with the same condition.
2012-02-25 07:48:52 +01:00
d55fa6f9cb
lavc: factorize setting got_packet_ptr in avcodec_encode_video2()
2012-02-25 07:48:46 +01:00
52953d61ca
lavc: signal no output when a NULL frame is passed to audio encoder without delay
2012-02-25 07:48:36 +01:00
99cff417f3
xwdenc: fix monow encoding
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Anton Khirnov <anton@khirnov.net>
2012-02-25 07:45:06 +01:00
904817cb9f
cdxl: fix ham6/8 on big endian
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-25 00:18:14 -05:00
19adb0bc2d
vorbisdec: add a flush() function
...
clear MDCT overlap buffer and reset previous window mode when seeking
2012-02-24 17:37:25 -05:00
830f70442a
fraps: release reference buffer on pix_fmt change.
...
Prevents crash when trying to copy from a non-existing plane in e.g.
a RGB32 reference image to a YUV420P target image
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-24 14:28:15 -08:00
87840eeb71
avcodec: disallow reget_buffer() if pix_fmt changed.
2012-02-24 14:28:15 -08:00
33cd32b389
kgv1: use avctx->get/release_buffer().
...
Also fixes crashes on corrupt bitstreams.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-24 14:28:15 -08:00
b716542691
mpegaudiodec: Prevent premature clipping of mp3 input buffer.
...
Instead of clipping extrasize based on EXTRABYTES, clip based on the
amount of buffer actually left. Without this fix, there are warbles
and other distortions in the test case below.
http://kevincennis.com/mix/assets/sounds/1901_voxfx.mp3
2012-02-24 13:47:04 -05:00
be129271ea
lcl: error out if uncompressed input buffer is smaller than framesize.
...
This prevents crashes when trying to read beyond the end of the buffer
while decoding frame data.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-24 07:28:57 -08:00
ab492ca2ab
mjpeg: abort decoding if packet is too large.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-24 07:28:43 -08:00
46b3fbc30b
golomb: use HAVE_BITS_REMAINING() macro to prevent infloop on EOF.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-24 07:28:33 -08:00
b44b41633f
get_bits: add HAVE_BITS_REMAINING macro.
2012-02-24 07:28:14 -08:00
447363870f
tiff: Prevent overreads in the type_sizes array.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-23 16:23:51 -08:00
e32548d133
tiff: Make the TIFF_LONG and TIFF_SHORT types unsigned.
...
TIFF v6.0 (unimplemented) adds signed equivalents.
2012-02-23 16:23:51 -08:00
2784d18791
SBR DSP x86: implement SSE sbr_hf_g_filt
...
Unrolling the main loop to process, instead of 4 elements:
- 8: minor gain of 2 cycles (not worth the extra object size)
- 2: loss of 8 cycles.
Assigning STEP to a register is a loss. Output address (Y) is almost always
unaligned.
Timings:
- C (32/64 bits): 117/109 cycles
- SSE: 57 cycles
Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
2012-02-23 15:50:09 -08:00
34454c761f
SBR DSP x86: implement SSE sbr_sum_square_sse
...
The 32bits targets have been compiled with -mfpmath=sse for proper reference.
sbr_sum_square C /32bits: 82c (unrolled)/102c
C /64bits: 69c (unrolled)/82c
SSE/32bits: 42c
SSE/64bits: 31c
Use of SSE4.1 dpps to perform the final sum is slower.
Not unrolling to perform 8 operations in a loop yields 10 more cycles.
Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
2012-02-23 15:50:06 -08:00
2e74a5abc2
SBR DSP: use intptr_t for the ixh parameter.
...
Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
2012-02-23 15:48:40 -08:00
480b133e6f
wavpack: Don't shift minclip/maxclip
...
Since we are clipping before we shift the values to
16 or 32 bits, we should not shift the min/max clip
values to compensate.
Fixes 8 and 24 bit lossy decoding.
Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
Signed-off-by: Anton Khirnov <anton@khirnov.net>
2012-02-23 20:43:39 +01:00
ff311c0918
lavc: drop encode() support for video.
...
All video encoders have been converted to encode2(), all new encoders
should also use only encode2().
2012-02-23 20:26:26 +01:00
171273fec8
snowenc: switch to encode2().
2012-02-23 20:26:14 +01:00
8d3348c2c4
snowenc: don't abuse input picture for storing information.
2012-02-23 20:26:04 +01:00
7340008f18
a64multienc: switch to encode2().
...
We have no decoder, so cannot test if the output is decodable.
2012-02-23 19:56:55 +01:00
cfc6ab3199
a64multienc: don't write into output buffer when there's no output.
2012-02-23 19:56:45 +01:00
4da6d194e5
libxvid: switch to encode2().
2012-02-23 19:55:23 +01:00
760b004086
tiffenc: switch to encode2().
2012-02-23 19:53:20 +01:00
62acb4937e
tiffenc: properly forward error codes in encode_frame().
2012-02-23 19:52:08 +01:00
2257f66ec5
lavc: drop libdirac encoder.
...
Libschroedinger is the preferred way to encode dirac video now, it
produces better output and has a nicer API.
2012-02-23 19:50:46 +01:00
577fed3b7c
gifenc: switch to encode2().
2012-02-23 19:50:46 +01:00
d8f3365fb0
libvpxenc: switch to encode2().
2012-02-23 19:50:46 +01:00
0ecf54f9dc
flashsvenc: switch to encode2().
2012-02-23 19:50:46 +01:00
01cb62aba2
lcl: don't overwrite input memory.
...
If the PNG filter is enabled, a PNG-style filter will run over the
input buffer, writing into the buffer. Therefore, if no zlib compression
was used, ensure that we copy into a temporary buffer, otherwise we
overwrite user-provided input data.
2012-02-23 10:31:46 -08:00
84db922bf9
libxavs: switch to encode2().
2012-02-23 19:25:50 +01:00
d3b577f00d
libxavs: add an AVClass at the beginning of XavsContext.
2012-02-23 19:25:50 +01:00
a5f848c86d
libxavs: split extradata writing out of encode_nals().
...
This is done in preparation for the following patch implementing
encode2().
This commit is analogous to 05d699222d
2012-02-23 19:25:50 +01:00
8e8124e173
ljpegenc: switch to encode2().
2012-02-23 19:25:50 +01:00
2b83e8b700
truemotion2: error out if the huffman tree has no nodes.
...
This prevents crashers and errors further down when reading nodes in the
empty tree.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-23 07:46:25 -08:00
3c0ed7d1a8
asv1enc: switch to encode2().
2012-02-23 14:11:08 +01:00
df53a47317
libschroedingerenc: switch to encode2().
2012-02-23 13:54:34 +01:00
278d88689b
ffv1enc: switch to encode2().
2012-02-23 13:51:29 +01:00
f7fa73ac91
libtheoraenc: switch to encode2().
2012-02-23 13:48:34 +01:00
6d9c27dc85
jpeglsenc: switch to encode2().
2012-02-23 11:12:39 +01:00
148fc99506
lclenc: switch to encode2().
2012-02-23 11:11:42 +01:00
21b46747ad
qtrleenc: switch to encode2().
2012-02-23 11:08:50 +01:00
62d5f9e5ca
flacdec: set channel_layout based on channel count
...
Channel layouts are specified in the FLAC format description at
http://flac.sourceforge.net/format.html
fixes Bug 209
2012-02-22 20:14:00 -05:00
3798205a77
mov: set channel layout for AC-3 streams based on the 'dac3' atom info
...
fixes Bug 225
2012-02-22 20:07:02 -05:00
1cd9a6154b
aac: fix infinite loop on end-of-frame with sequence of 1-bits.
...
Based-on-work-by: Ronald S. Bultje <rsbultje@gmail.com>
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-22 11:23:43 -08:00
6bbaf6e0dd
mlpdec_parser: fix a few channel layouts.
...
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-22 10:50:22 -05:00
b5696ff2b8
prores: use natural integer type for the codebook index
...
The operations that use it require it to be promoted to a larger (natural)
type and thus perform sign extension on it.
While an optimal compiler may account for this, gcc 4.6 (for x86 Windows)
fails. Using the natural integer type provides a 2% speedup for Win64
and 1% for Win32.
Signed-off-by: Diego Biurrun <diego@biurrun.de>
2012-02-22 09:21:39 +01:00
5d42ac7ffb
mpegvideo_enc: only allocate output packet when we know there will be output
...
Fixes a memleak.
2012-02-21 22:47:01 +01:00
79c7064c5f
sunrast: Add a sample request for RMP_RAW colormap.
...
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-21 16:00:06 -05:00
70749c483c
avcodec: do not override pts or duration from the audio encoder
...
This allows encoders to set pts and/or duration even if they do not use
CODEC_CAP_DELAY.
2012-02-21 15:18:51 -05:00
b0f29db5c2
Mark mutable static data const where appropriate.
2012-02-21 09:47:07 -08:00
6a4cf065c7
dvbsubdec: avoid undefined signed left shift in RGBA macro
2012-02-21 16:01:31 +01:00
ca085e667b
mlpdec: use av_log_ask_for_sample()
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Janne Grunau <janne-libav@jannau.net>
2012-02-21 16:01:31 +01:00
08630d25a2
png: make .long_name more descriptive
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Diego Biurrun <diego@biurrun.de>
2012-02-21 15:47:05 +01:00
3ab9a2a557
rv34: change most "int stride" into "ptrdiff_t stride".
...
This prevents having to sign-extend on 64-bit systems with 32-bit ints,
such as x86-64. Also fixes crashes on systems where we don't do it and
arguments are not in registers, such as Win64 for all weight functions.
2012-02-20 14:58:25 -08:00
770a5c6d02
adpcmenc: Use correct frame_size for Yamaha ADPCM.
...
Output packet size should match avctx->block_align. The target output packet
size is 1024 bytes.
Before:
mono - 1024 samples -> 512 bytes
stereo - 2048 samples -> 2048 bytes
After:
mono - 2048 samples -> 1024 bytes
stereo - 1024 samples -> 1024 bytes
2012-02-20 15:52:32 -05:00
91a28b0e8e
avcodec: add ff_samples_to_time_base() convenience function to internal.h
2012-02-20 15:20:17 -05:00
41ac9bb253
adx parser: set duration
2012-02-20 15:08:41 -05:00
b3a4c7e0f1
mlp parser: set duration instead of frame_size
2012-02-20 15:08:41 -05:00
2460b168b4
gsm parser: set duration
2012-02-20 15:08:41 -05:00
7575ffac8a
mpegaudio parser: set duration instead of frame_size
2012-02-20 15:08:40 -05:00
16e54ac725
(e)ac3 parser: set duration instead of frame_size
2012-02-20 15:08:40 -05:00
c7f3f1c91e
flac parser: set duration instead of frame_size
2012-02-20 15:08:40 -05:00
e9cda85351
avcodec: add duration field to AVCodecParserContext
...
This will allow parsers to export the duration of the current frame being
output, if known, instead of using AVCodecContext.frame_size.
2012-02-20 15:08:40 -05:00
0996f406c4
pnmdec: remove useless .pix_fmts
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-20 13:46:57 -05:00
e00959a9b1
libmp3lame: support float and s32 sample formats
2012-02-20 12:32:31 -05:00
e232225276
libmp3lame: renaming, rearrangement, alignment, and comments
2012-02-20 12:32:30 -05:00
232e16dd02
libmp3lame: use the LAME default bit rate
...
Also, only set bit rate for CBR.
2012-02-20 12:32:30 -05:00
1f516c0451
libmp3lame: use avpriv_mpegaudio_decode_header() for output frame parsing
2012-02-20 12:32:30 -05:00
e3d2c89e9d
libmp3lame: cosmetics: remove some pointless comments
2012-02-20 12:32:30 -05:00
bf909fc456
libmp3lame: convert some debugging code to av_dlog()
...
also remove unneeded commented-out full frame data debugging
2012-02-20 12:32:30 -05:00
469d2a8e8e
libmp3lame: remove outdated comment.
...
We now require at least libmp3lame 3.98.3.
lame_encode_buffer_interleaved() still doesn't work for mono, but it does not
"die"; it just expects a stereo interleaved buffer.
2012-02-20 12:32:30 -05:00
35cfd7d09c
libmp3lame: do not set coded_frame->key_frame.
...
it is already set in avcodec_alloc_frame()
2012-02-20 12:32:30 -05:00
8dad25ebf7
libmp3lame: improve error handling in MP3lame_encode_init()
2012-02-20 12:32:30 -05:00
310c372e12
libmp3lame: remove unneeded 'stereo' field from Mp3AudioContext
2012-02-20 12:32:30 -05:00
55fd7da107
pcxenc: switch to encode2().
2012-02-20 07:50:44 +01:00
fb11e22fda
sgienc: switch to encode2().
2012-02-20 07:50:44 +01:00
61eaf45c99
targaenc: switch to encode2().
2012-02-20 07:50:44 +01:00
1e742ea3c8
targaenc: don't modify input frame.
...
Set the pict_type/key_frame properties on the coded picture.
2012-02-20 07:50:44 +01:00
3227770092
roqvideoenc: switch to encode2().
2012-02-20 07:50:44 +01:00
4fd7cfef0b
roqvideoenc: add const qualifier to the input frame.
2012-02-20 07:50:44 +01:00
1ea5755046
pnmenc: switch to encode2().
2012-02-20 07:50:44 +01:00
bc9c70e5a3
huffyuv: switch to encode2().
2012-02-20 07:50:44 +01:00
2abee9be82
v410enc: switch to encode2().
2012-02-20 07:50:44 +01:00
11505f39e1
zmbvenc: switch to encode2().
2012-02-20 07:50:44 +01:00
8c8c7b5e37
zmbvenc: move header writing to the end of encode_frame().
...
This makes switching to encode2() simpler, because it allows us to know
exactly how large should the output buffer be before we start writing
into it.
2012-02-20 07:50:44 +01:00
8fb26950ed
h264: don't use redzone in loopfilter on win64.
...
Red zone usage is not allowed in the Win64 ABI.
2012-02-19 15:31:03 -08:00
aac63cef20
examples: unbreak compilation
...
Update api so it will compile again.
2012-02-19 19:10:28 +01:00
e04ca1d4ce
ttadec: cosmetics: reindent
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-19 13:04:10 -05:00
566df2eea2
sunrast: use RLE trigger macro inplace of the hard coded value.
...
Signed-off-by: Anton Khirnov <anton@khirnov.net>
2012-02-19 15:55:57 +01:00
1a58daed0f
sunrastenc: set keyframe flag for the output packet.
...
Signed-off-by: Anton Khirnov <anton@khirnov.net>
2012-02-19 15:54:27 +01:00
445a7d48b1
mpegvideo_enc: switch to encode2().
2012-02-19 08:26:30 +01:00
5455384219
mpegvideo_enc: force encoding delay of at least 1 frame when low_delay=0
...
This allows the following commit to extrapolate better dts for the first
frame. Pts difference between the first two frames is reused as the
difference between pts and dts of the first frame.
2012-02-19 08:22:48 +01:00
6d702dc072
proresenc: force bitrate not to exceed given limit
...
Apple ProRes Format Specifications mentions target data size for every frame,
so make sure frame meets it. This also allows encoder to demand much smaller
packet sizes for output.
2012-02-18 18:34:01 +01:00
c742ab4e81
vc1parse: call vc1_init_common().
...
The parser uses VLC tables initialized in vc1_common_init(), therefore
we should call this function on parser init also.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-18 09:16:39 -08:00
9d3050d3e9
wma: don't return 0 on invalid packets.
...
Return 0 means "please return the same data again", i.e. it causes an
infinite loop. Instead, return an error.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-18 09:13:38 -08:00
74699ac8c8
mjpegb: don't return 0 at the end of frame decoding.
...
Return 0 indicates "please return the same data again", i.e. it causes
an infinite loop. Instead, return that we consumed the buffer if we
finished decoding succesfully, or return an error if an error occurred.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-18 08:41:45 -08:00
b1af4e9c27
vp8dsp: split long line.
...
Signed-off-by: Martin Storsjö <martin@martin.st>
2012-02-18 02:32:09 +02:00
ce7aee9b73
dpcm: ignore extra unpaired bytes in stereo streams.
...
Fixes: CVE-2011-3951
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
2012-02-17 15:42:23 -08:00
3e13005cac
mp3on4: require a minimum framesize.
...
If bufsize < headersize, init_get_bits() will be called with a negative
number, causing it to fail and any subsequent call to get_bits() will
crash because it reads from a NULL pointer.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-17 15:32:23 -08:00
c0994e39d7
mpc7: assign an error level + context to av_log() msg.
2012-02-17 15:28:35 -08:00
84c202cc37
huffyuv: error out on bit overrun.
...
On EOF, get_bits() will continuously return 0, causing an infinite
loop.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-17 15:23:20 -08:00
0733375059
dct-test: Add the missing ff_ prefix to the altivec functions
...
Signed-off-by: Martin Storsjö <martin@martin.st>
2012-02-18 00:22:25 +02:00
89baf35996
dct-test: Remove a stray declaration of a nonexistent function
...
Signed-off-by: Martin Storsjö <martin@martin.st>
2012-02-18 00:22:24 +02:00
af468015d9
als: prevent infinite loop in zero_remaining().
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-17 12:35:08 -08:00
941fc1ea1e
cook: prevent div-by-zero if channels is zero.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-17 12:35:07 -08:00
e9b380a7a5
pamenc: switch to encode2().
2012-02-17 20:46:37 +01:00
3cc77ded4f
svq1enc: switch to encode2().
2012-02-17 20:46:37 +01:00
6a047213ac
dvenc: switch to encode2().
2012-02-17 20:46:37 +01:00
b3566a6a39
dpxenc: switch to encode2().
2012-02-17 20:46:37 +01:00
83c7fe3245
pngenc: switch to encode2().
2012-02-17 20:46:37 +01:00
ab3a410cf0
v210enc: switch to encode2().
2012-02-17 20:46:37 +01:00
f0366fec56
xwdenc: switch to encode2().
2012-02-17 20:46:37 +01:00
f2a4559c77
ttadec: use branchless unsigned-to-signed unfolding
2012-02-17 14:35:35 -05:00
d7840529b6
avcodec: add a Sun Rasterfile encoder
...
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-17 14:28:56 -05:00
1f1fbcfa71
sunrast: Move common defines to a new header file.
...
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-17 14:23:40 -05:00
b5c626fdf3
cdxl: fix video decoding for some files
...
Width is padded for ham encodings too.
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-17 14:20:18 -05:00
323b9da969
ttadec: remove dead code
...
The unused code being removed is for encoding only and therefore is not needed
by the decoder.
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-17 13:38:09 -05:00
5d9ad5425f
prores: initialise encoder and decoder parts only when needed
2012-02-17 14:11:48 +01:00
52e4018be4
flac: fix infinite loops on all-zero input or end-of-stream.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-16 17:08:29 -08:00
b4027d9749
wmapro: change max. block size to 13 bits.
...
WMApro actually support 13-bits block sizes (potentially even up to 14),
and thus we should support that also. If we get block sizes beyond what
the decoder can handle (14 is possible depending on s->decode_flags),
error out instead of crashing.
2012-02-16 16:15:36 -08:00
204cb29b3c
shorten: Use separate pointers for the allocated memory for decoded samples.
...
Fixes invalid free() if any of the buffers are not allocated due to either
not decoding a header or an error prior to allocating all buffers.
Fixes CVE-2012-0858
CC: libav-stable@libav.org
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-16 15:18:45 -05:00
c509f4f747
atrac3: Fix crash in tonal component decoding.
...
Add a check to avoid writing past the end of the channel_unit.components[]
array.
Bug Found by: cosminamironesei
Fixes CVE-2012-0853
CC: libav-stable@libav.org
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-16 15:18:45 -05:00
9fb7a5af97
ws_snd1: Fix wrong samples counts.
...
This makes the check that avoids overwrite of the samples array actually
work properly.
fixes CVE-2012-0848
CC: libav-stable@libav.org
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Justin Ruggles <justin.ruggles@gmail.com>
2012-02-16 15:18:45 -05:00
c6643fddba
golomb: avoid infinite loop on all-zero input (or end of buffer).
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-16 08:36:08 -08:00
f320fb894c
bethsoftvid: pass palette in side data instead of in a separate packet.
...
Update FATE reference to account for now non-existent palette packet.
This also fixes the FATE test if frame data is not initialized in
get_buffer(), so update comment in avconv accordingly.
2012-02-16 10:47:11 -05:00
17b11ffec7
proresenc: initialise 'sign' variable
2012-02-16 06:48:24 +01:00
f3e084909b
mpegaudio: replace memcpy by SIMD code
...
By replacing memcpy with an unrolled loop using the alignment knowledge
it has, some speedup can be obtained.
Before (gcc 4.6.1): ~400 cycles
After: ~370 cycles
Overall, around 2% speed increase when decoding a 2400s mp3 to f32le.
Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
2012-02-15 20:11:54 -08:00
ae591aeea5
vc1: prevent using last_frame as a reference for I/P first frame.
...
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
2012-02-15 19:58:10 -08:00
210f72845c
ppc: Add ff_ prefix to nonstatic symbols
...
Signed-off-by: Martin Storsjö <martin@martin.st>
2012-02-15 22:07:29 +02:00
f73673a770
sh4: Add ff_ prefix to nonstatic symbols
...
Signed-off-by: Martin Storsjö <martin@martin.st>
2012-02-15 22:07:26 +02:00
efd29844eb
mpegvideo: Add ff_ prefix to nonstatic functions
...
Signed-off-by: Martin Storsjö <martin@martin.st>
2012-02-15 22:07:23 +02:00
0ca1bdb37d
rtjpeg: Add ff_ prefix to nonstatic symbols
...
Signed-off-by: Martin Storsjö <martin@martin.st>
2012-02-15 22:07:20 +02:00
Justin Ruggles
Aneesh Dogra
Ronald S. Bultje
Michael Niedermayer
Anton Khirnov
Mashiat Sarker Shakkhar
Alex Converse
Martin Storsjö
Derek Buitenhuis
Diego Biurrun
Christophe Gisquet
Vitor Sessak
Kostya Shishkov
Phil Barrett
Reinhard Tartler
Paul B Mahol
Tim Walker
Dale Curtis
Janne Grunau
Luca Barbato