From ecfff0e9929f399119437cd7113bad1cd968e8ea Mon Sep 17 00:00:00 2001 From: Jordi Ortiz Date: Tue, 24 Jul 2012 19:56:39 +0200 Subject: [PATCH] sctp: add port missing error message MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Without this patch a user a bit absent-minded may not notice that the connection doesn't work because the port is missing. Signed-off-by: Martin Storsjö --- libavformat/sctp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/sctp.c b/libavformat/sctp.c index 7bcb5ae0a9..b8ab63e7da 100644 --- a/libavformat/sctp.c +++ b/libavformat/sctp.c @@ -170,8 +170,12 @@ static int sctp_open(URLContext *h, const char *uri, int flags) av_url_split(proto, sizeof(proto), NULL, 0, hostname, sizeof(hostname), &port, path, sizeof(path), uri); - if (strcmp(proto,"sctp") || port <= 0 || port >= 65536) + if (strcmp(proto, "sctp")) return AVERROR(EINVAL); + if (port <= 0 || port >= 65536) { + av_log(s, AV_LOG_ERROR, "Port missing in uri\n"); + return AVERROR(EINVAL); + } s->max_streams = 0; p = strchr(uri, '?');