From bf800c7db8aae141ed79adf6e97398190521944c Mon Sep 17 00:00:00 2001 From: Anton Khirnov Date: Wed, 3 Nov 2010 06:29:04 +0000 Subject: [PATCH] matroskadec: skip invalid tags with no TagName fixes segfault in issue 2328 Originally committed as revision 25659 to svn://svn.ffmpeg.org/ffmpeg/trunk --- libavformat/matroskadec.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 136839ad89..820140fb9e 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -1033,6 +1033,11 @@ static void matroska_convert_tag(AVFormatContext *s, EbmlList *list, for (i=0; i < list->nb_elem; i++) { const char *lang = strcmp(tags[i].lang, "und") ? tags[i].lang : NULL; + + if (!tags[i].name) { + av_log(s, AV_LOG_WARNING, "Skipping invalid tag with no TagName.\n"); + continue; + } if (prefix) snprintf(key, sizeof(key), "%s/%s", prefix, tags[i].name); else av_strlcpy(key, tags[i].name, sizeof(key)); if (tags[i].def || !lang) {