RepoMirrors
/
ffmpeg
mirror of https://git.ffmpeg.org/ffmpeg.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

qpeg: avoid pointless invalid memcpy() 

If refdata was NULL, the memcpy() ended up copying the same memory
block onto itself, which is not only pointless, but also undefined
behavior.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
(cherry picked from commit 921706691a)

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
This commit is contained in:
wm4 2015-01-13 14:47:47 +01:00 committed by Michael Niedermayer
parent 763e6ecf83
commit 8a6770a214
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
libavcodec/qpeg.c
View File

@ -120,12 +120,13 @@ static void av_noinline qpeg_decode_inter(QpegContext *qctx, uint8_t *dst,
int filled = 0; int filled = 0;
int orig_height; int orig_height;
if(!refdata) if (refdata) {
refdata= dst; /* copy prev frame */
for (i = 0; i < height; i++)
/* copy prev frame */ memcpy(dst + (i * stride), refdata + (i * stride), width);
for(i = 0; i < height; i++) } else {
memcpy(dst + (i * stride), refdata + (i * stride), width); refdata = dst;
}
orig_height = height; orig_height = height;
height--; height--;