avcodec/h261dec: make while get_bits loop more robust by checking bits left

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
This commit is contained in:
Michael Niedermayer 2013-10-30 14:23:30 +01:00
parent b0f8b5c819
commit 719dbe86ea
1 changed files with 8 additions and 2 deletions

View File

@ -125,8 +125,11 @@ static int h261_decode_gob_header(H261Context *h)
}
/* GEI */
while (get_bits1(&s->gb) != 0)
while (get_bits1(&s->gb) != 0) {
skip_bits(&s->gb, 8);
if (get_bits_left(&s->gb) <= 0)
return AVERROR_INVALIDDATA;
}
if (s->qscale == 0) {
av_log(s->avctx, AV_LOG_ERROR, "qscale has forbidden 0 value\n");
@ -505,8 +508,11 @@ static int h261_decode_picture_header(H261Context *h)
skip_bits1(&s->gb); /* Reserved */
/* PEI */
while (get_bits1(&s->gb) != 0)
while (get_bits1(&s->gb) != 0) {
skip_bits(&s->gb, 8);
if (get_bits_left(&s->gb) <= 0)
return AVERROR_INVALIDDATA;
}
/* H.261 has no I-frames, but if we pass AV_PICTURE_TYPE_I for the first
* frame, the codec crashes if it does not contain all I-blocks