From 6c0107822d3ed7588fa857c3ed1ee886b4ba62e9 Mon Sep 17 00:00:00 2001 From: Stefano Sabatini Date: Wed, 29 Aug 2012 13:08:49 +0200 Subject: [PATCH] lavfi/mp=decimate: fix off-by-one logic in diff_C() x loop Set x offset values in the range 0-7, rather than in the range 8-1. The y loop is changed accordingly, to avoid confusion. This also fixes output difference with the new pending native decimate filter. --- libavfilter/libmpcodecs/vf_decimate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/libmpcodecs/vf_decimate.c b/libavfilter/libmpcodecs/vf_decimate.c index 1fd7bce3d3..2d2aaf0abd 100644 --- a/libavfilter/libmpcodecs/vf_decimate.c +++ b/libavfilter/libmpcodecs/vf_decimate.c @@ -82,8 +82,8 @@ static int diff_MMX(unsigned char *old, unsigned char *new, int os, int ns) static int diff_C(unsigned char *old, unsigned char *new, int os, int ns) { int x, y, d=0; - for (y = 8; y; y--) { - for (x = 8; x; x--) { + for (y = 0; y < 8; y++) { + for (x = 0; x < 8; x++) { d += abs(new[x] - old[x]); } new += ns;