From 53886d6955134be8acc26f336bdf068fd970669d Mon Sep 17 00:00:00 2001 From: Ricardo Constantino Date: Sun, 11 Oct 2015 17:11:01 +0100 Subject: [PATCH] avcodec/webvttdec: Deal with WebVTT escapes Bare ampersand characters are still accepted, even though out-of-spec. Also fixes adjacent tags not being parsed. Fixes trac #4915 Signed-off-by: Ricardo Constantino --- libavcodec/webvttdec.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavcodec/webvttdec.c b/libavcodec/webvttdec.c index 1284a172c4..fb1a422124 100644 --- a/libavcodec/webvttdec.c +++ b/libavcodec/webvttdec.c @@ -37,11 +37,14 @@ static const struct { {"", "{\\b1}"}, {"", "{\\b0}"}, {"", "{\\u1}"}, {"", "{\\u0}"}, {"{", "\\{"}, {"}", "\\}"}, // escape to avoid ASS markup conflicts + {">", ">"}, {"<", "<"}, + {"‎", ""}, {"‏", ""}, // FIXME: properly honor bidi marks + {"&", "&"}, {" ", "\\h"}, }; static int webvtt_event_to_ass(AVBPrint *buf, const char *p) { - int i, skip = 0; + int i, again, skip = 0; while (*p) { @@ -51,12 +54,18 @@ static int webvtt_event_to_ass(AVBPrint *buf, const char *p) if (!strncmp(p, from, len)) { av_bprintf(buf, "%s", webvtt_tag_replace[i].to); p += len; + again = 1; break; } } if (!*p) break; + if (again) { + again = 0; + skip = 0; + continue; + } if (*p == '<') skip = 1; else if (*p == '>')