From 515c0247a3062ca4639e457c81d2f58c504e9e8f Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Sat, 16 Sep 2023 23:36:29 +0200 Subject: [PATCH] avcodec/apedec: Fix an integer overflow in predictor_update_filter() Fixes: signed integer overflow: -2147483506 + -801380 cannot be represented in type 'int' Fixes: 62164/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-6578985923117056 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/apedec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index 62cb397490..8bfbb75b41 100644 --- a/libavcodec/apedec.c +++ b/libavcodec/apedec.c @@ -1220,7 +1220,7 @@ static av_always_inline int predictor_update_filter(APEPredictor64 *p, if (interim_mode < 1) { predictionA = (int32_t)predictionA; predictionB = (int32_t)predictionB; - p->lastA[filter] = decoded + ((int32_t)(predictionA + (predictionB >> 1)) >> 10); + p->lastA[filter] = (int32_t)(decoded + (unsigned)((int32_t)(predictionA + (predictionB >> 1)) >> 10)); } else { p->lastA[filter] = decoded + ((int64_t)((uint64_t)predictionA + (predictionB >> 1)) >> 10); }