From 4e6fa5be3ce5a66e9420377dceedffb6cadfdad4 Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Fri, 2 Nov 2012 00:24:26 +0100 Subject: [PATCH] Revert "cmdutils: allow specifying the file for -report" This reverts commit 841bf0ef240f0d862b1f07076e079829456fb117. This does not fully work as the file is used before the filename is parsed so not all information is written in the specified file. --- cmdutils.c | 11 ----------- cmdutils.h | 2 -- cmdutils_common_opts.h | 1 - 3 files changed, 14 deletions(-) diff --git a/cmdutils.c b/cmdutils.c index 248462fd80..f696700142 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -528,17 +528,6 @@ int opt_loglevel(void *optctx, const char *opt, const char *arg) return 0; } -int opt_report_file(void *optctx, const char *opt, const char *arg) -{ - report_file = fopen(arg, "w"); - if (!report_file) { - av_log(NULL, AV_LOG_ERROR, "Failed to open report \"%s\": %s\n", - arg, strerror(errno)); - return AVERROR(errno); - } - return 0; -} - int opt_report(const char *opt) { char filename[64]; diff --git a/cmdutils.h b/cmdutils.h index 74bee61060..931b634f4a 100644 --- a/cmdutils.h +++ b/cmdutils.h @@ -84,8 +84,6 @@ int opt_loglevel(void *optctx, const char *opt, const char *arg); int opt_report(const char *opt); -int opt_report_file(void *optctx, const char *opt, const char *arg); - int opt_max_alloc(void *optctx, const char *opt, const char *arg); int opt_cpuflags(void *optctx, const char *opt, const char *arg); diff --git a/cmdutils_common_opts.h b/cmdutils_common_opts.h index 2e1cf7db03..bfd71feb7d 100644 --- a/cmdutils_common_opts.h +++ b/cmdutils_common_opts.h @@ -19,6 +19,5 @@ { "debug" , HAS_ARG, {.func_arg = opt_codec_debug}, "set debug flags", "flags" }, { "fdebug" , HAS_ARG, {.func_arg = opt_codec_debug}, "set debug flags", "flags" }, { "report" , 0, {(void*)opt_report}, "generate a report" }, - { "report_file", HAS_ARG, {.func_arg = opt_report_file}, "filename for storing the report" }, { "max_alloc" , HAS_ARG, {.func_arg = opt_max_alloc}, "set maximum size of a single allocated block", "bytes" }, { "cpuflags" , HAS_ARG | OPT_EXPERT, {.func_arg = opt_cpuflags}, "force specific cpu flags", "flags" },