RepoMirrors
/
ffmpeg
mirror of https://git.ffmpeg.org/ffmpeg.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

avcodec/alac: Fix integer overflow in LPC 

Fixes: signed integer overflow: 2147483628 + 128 cannot be represented in type 'int'
Fixes: 17783/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5146470595952640

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
Michael Niedermayer 2019-10-01 00:16:20 +02:00
parent a76897e19c
commit 44b73a0568
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libavcodec/alac.c
View File

@ -215,7 +215,7 @@ static void lpc_prediction(int32_t *error_buffer, uint32_t *buffer_out,
/* LPC prediction */ /* LPC prediction */
for (j = 0; j < lpc_order; j++) for (j = 0; j < lpc_order; j++)
val += (pred[j] - d) * lpc_coefs[j]; val += (pred[j] - d) * lpc_coefs[j];
val = (val + (1 << (lpc_quant - 1))) >> lpc_quant; val = (val + (1LL << (lpc_quant - 1))) >> lpc_quant;
val += d + error_val; val += d + error_val;
buffer_out[i] = sign_extend(val, bps); buffer_out[i] = sign_extend(val, bps);