RepoMirrors
/
ffmpeg
mirror of https://git.ffmpeg.org/ffmpeg.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

avcodec/x86/sbrdsp: Remove obsolete SSE function 

x64 always has MMX, MMXEXT, SSE and SSE2 and this means
that some functions for MMX, MMXEXT and 3dnow are always
overridden by other functions (unless one e.g. explicitly
disables SSE2) for x64. So given that the only systems that
benefit from ff_sbr_qmf_deint_bfly_sse are truely ancient 32bit x86s
it is removed.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
This commit is contained in:
Andreas Rheinhardt 2022-06-10 20:10:45 +02:00
parent 4618f36a24
commit 3d151bab32
2 changed files with 1 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
libavcodec/x86/sbrdsp.asm
View File

@ -251,7 +251,7 @@ cglobal sbr_neg_odd_64, 1,2,4,z
REP_RET REP_RET
; void ff_sbr_qmf_deint_bfly_sse2(float *v, const float *src0, const float *src1) ; void ff_sbr_qmf_deint_bfly_sse2(float *v, const float *src0, const float *src1)
%macro SBR_QMF_DEINT_BFLY 0 INIT_XMM sse2
cglobal sbr_qmf_deint_bfly, 3,5,8, v,src0,src1,vrev,c cglobal sbr_qmf_deint_bfly, 3,5,8, v,src0,src1,vrev,c
mov cq, 64*4-2*mmsize mov cq, 64*4-2*mmsize
lea vrevq, [vq + 64*4] lea vrevq, [vq + 64*4]
@ -260,17 +260,10 @@ cglobal sbr_qmf_deint_bfly, 3,5,8, v,src0,src1,vrev,c
mova m1, [src1q] mova m1, [src1q]
mova m4, [src0q+cq+mmsize] mova m4, [src0q+cq+mmsize]
mova m5, [src1q+mmsize] mova m5, [src1q+mmsize]
%if cpuflag(sse2)
pshufd m2, m0, q0123 pshufd m2, m0, q0123
pshufd m3, m1, q0123 pshufd m3, m1, q0123
pshufd m6, m4, q0123 pshufd m6, m4, q0123
pshufd m7, m5, q0123 pshufd m7, m5, q0123
%else
shufps m2, m0, m0, q0123
shufps m3, m1, m1, q0123
shufps m6, m4, m4, q0123
shufps m7, m5, m5, q0123
%endif
addps m5, m2 addps m5, m2
subps m0, m7 subps m0, m7
addps m1, m6 addps m1, m6
@ -284,13 +277,6 @@ cglobal sbr_qmf_deint_bfly, 3,5,8, v,src0,src1,vrev,c
sub cq, 2*mmsize sub cq, 2*mmsize
jge .loop jge .loop
REP_RET REP_RET
%endmacro
INIT_XMM sse
SBR_QMF_DEINT_BFLY
INIT_XMM sse2
SBR_QMF_DEINT_BFLY
INIT_XMM sse2 INIT_XMM sse2
cglobal sbr_qmf_pre_shuffle, 1,4,6,z cglobal sbr_qmf_pre_shuffle, 1,4,6,z

2
libavcodec/x86/sbrdsp_init.c
View File

@ -34,7 +34,6 @@ void ff_sbr_hf_gen_sse(float (*X_high)[2], const float (*X_low)[2],
float bw, int start, int end); float bw, int start, int end);
void ff_sbr_neg_odd_64_sse(float *z); void ff_sbr_neg_odd_64_sse(float *z);
void ff_sbr_qmf_post_shuffle_sse(float W[32][2], const float *z); void ff_sbr_qmf_post_shuffle_sse(float W[32][2], const float *z);
void ff_sbr_qmf_deint_bfly_sse(float *v, const float *src0, const float *src1);
void ff_sbr_qmf_deint_bfly_sse2(float *v, const float *src0, const float *src1); void ff_sbr_qmf_deint_bfly_sse2(float *v, const float *src0, const float *src1);
void ff_sbr_qmf_pre_shuffle_sse2(float *z); void ff_sbr_qmf_pre_shuffle_sse2(float *z);
@ -67,7 +66,6 @@ av_cold void ff_sbrdsp_init_x86(SBRDSPContext *s)
s->hf_g_filt = ff_sbr_hf_g_filt_sse; s->hf_g_filt = ff_sbr_hf_g_filt_sse;
s->hf_gen = ff_sbr_hf_gen_sse; s->hf_gen = ff_sbr_hf_gen_sse;
s->qmf_post_shuffle = ff_sbr_qmf_post_shuffle_sse; s->qmf_post_shuffle = ff_sbr_qmf_post_shuffle_sse;
s->qmf_deint_bfly = ff_sbr_qmf_deint_bfly_sse;
s->qmf_deint_neg = ff_sbr_qmf_deint_neg_sse; s->qmf_deint_neg = ff_sbr_qmf_deint_neg_sse;
s->autocorrelate = ff_sbr_autocorrelate_sse; s->autocorrelate = ff_sbr_autocorrelate_sse;
} }