From 2d7c1479c204ef2a8b9f1c0273e0e6cddd634ed5 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Mon, 31 Jul 2023 11:50:21 +0200 Subject: [PATCH] avcodec/nvenc: Remove always-true check nvenc_store_frame_data() is always called with frame != NULL (checked at the beginning of nvenc_send_frame()); in fact, frame is dereferenced unconditionally after the block guarded by the check for frame. Therefore Coverity complains about this in issue #1538295. Signed-off-by: Andreas Rheinhardt --- libavcodec/nvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 0b6417674e..505b95f93c 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -2249,7 +2249,7 @@ static int nvenc_store_frame_data(AVCodecContext *avctx, NV_ENC_PIC_PARAMS *pic_ // in case the encoder got reconfigured, there might be leftovers av_buffer_unref(&frame_data->frame_opaque_ref); - if (frame && frame->opaque_ref && avctx->flags & AV_CODEC_FLAG_COPY_OPAQUE) { + if (frame->opaque_ref && avctx->flags & AV_CODEC_FLAG_COPY_OPAQUE) { frame_data->frame_opaque_ref = av_buffer_ref(frame->opaque_ref); if (!frame_data->frame_opaque_ref) return AVERROR(ENOMEM);