RepoMirrors
/
ffmpeg
mirror of https://git.ffmpeg.org/ffmpeg.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

lavf/mux: Always call write_trailer() from av_write_trailer() to avoid a leak. 

Fixes ticket #4049.
This commit is contained in:
Carl Eugen Hoyos 2014-11-20 10:14:51 +01:00
parent c661601f45
commit 25ccf5df72
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libavformat/mux.c
View File

@ -926,7 +926,7 @@ int av_write_trailer(AVFormatContext *s)
for (;; ) {
AVPacket pkt;
ret = interleave_packet(s, &pkt, NULL, 1);
if (ret < 0) //FIXME cleanup needed for ret<0 ?
if (ret < 0)
goto fail;
if (!ret)
break;
@ -943,10 +943,14 @@ int av_write_trailer(AVFormatContext *s)
goto fail;
}
if (s->oformat->write_trailer)
ret = s->oformat->write_trailer(s);
fail:
if (s->oformat->write_trailer)
if (ret >= 0) {
ret = s->oformat->write_trailer(s);
} else {
s->oformat->write_trailer(s);
}
if (s->pb)
avio_flush(s->pb);
if (ret == 0)