From 241f8465d07ecc0696bcda994a1f44d836b8809c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= Date: Wed, 15 Feb 2012 15:07:09 +0100 Subject: [PATCH] lavfi/abuffer: init the data planes with NULL pointers. Samples buffer ref is allocated and loaded with the uninitialized data pointers: av_asrc_buffer_add_buffer() -> av_asrc_buffer_add_samples() -> avfilter_get_audio_buffer_ref_from_arrays(data, ...) ...which leads to a crash with at least lavfi/ashowinfo in case of !NULL (see the for loop while samplesref->data[plane]). --- libavfilter/asrc_abuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/asrc_abuffer.c b/libavfilter/asrc_abuffer.c index ad71e12c5b..5eca785f1a 100644 --- a/libavfilter/asrc_abuffer.c +++ b/libavfilter/asrc_abuffer.c @@ -234,7 +234,7 @@ int av_asrc_buffer_add_buffer(AVFilterContext *ctx, int sample_fmt, int64_t channel_layout, int planar, int64_t pts, int av_unused flags) { - uint8_t *data[8]; + uint8_t *data[8] = {0}; int linesize[8]; int nb_channels = av_get_channel_layout_nb_channels(channel_layout), nb_samples = buf_size / nb_channels / av_get_bytes_per_sample(sample_fmt);