From 17f0c3be8ecbf3555d763007bd51583ad3f63cc0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Reimar=20D=C3=B6ffinger?= Date: Tue, 8 Sep 2009 08:30:56 +0000 Subject: [PATCH] Try to clarify that anyone using get_bits must check for buffer overrun themselves, get_bits does not do anything in that regard. Originally committed as revision 19794 to svn://svn.ffmpeg.org/ffmpeg/trunk --- libavcodec/get_bits.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h index 877f909a74..19333c2f78 100644 --- a/libavcodec/get_bits.h +++ b/libavcodec/get_bits.h @@ -489,6 +489,9 @@ static inline int check_marker(GetBitContext *s, const char *msg) * @param buffer bitstream buffer, must be FF_INPUT_BUFFER_PADDING_SIZE bytes larger then the actual read bits * because some optimized bitstream readers read 32 or 64 bit at once and could read over the end * @param bit_size the size of the buffer in bits + * + * While GetBitContext stores the buffer size, for performance reasons you are + * responsible for checking for the buffer end yourself (take advantage of the padding)! */ static inline void init_get_bits(GetBitContext *s, const uint8_t *buffer, int bit_size)