RepoMirrors
/
ffmpeg
mirror of https://git.ffmpeg.org/ffmpeg.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

avcodec/alac: fix undefined behavior with INT_MIN in lpc_prediction() 

Fixes: signed integer overflow: -2147483648 * -1 cannot be represented in type 'int'
Fixes: 16786/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5632818851348480

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
Michael Niedermayer 2019-09-06 10:36:43 +02:00
parent 72db18e929
commit 0831cbfe09
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libavcodec/alac.c
View File

@ -222,7 +222,7 @@ static void lpc_prediction(int32_t *error_buffer, uint32_t *buffer_out,
/* adapt LPC coefficients */ /* adapt LPC coefficients */
error_sign = sign_only(error_val); error_sign = sign_only(error_val);
if (error_sign) { if (error_sign) {
for (j = 0; j < lpc_order && (int)error_val * error_sign > 0; j++) { for (j = 0; j < lpc_order && (int)(error_val * error_sign) > 0; j++) {
int sign; int sign;
val = d - pred[j]; val = d - pred[j];
sign = sign_only(val) * error_sign; sign = sign_only(val) * error_sign;