From 01a4c3596942dad396834fea155173590687c59d Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Mon, 7 Sep 2020 20:32:51 +0200 Subject: [PATCH] avformat/dashdec: Don't leave representation in inconsistent state on error This currently doesn't cause any trouble, because the only caller did not clean up the representation upon error at all; but fixing this is a prerequisite for doing so. Reviewed-by: Steven Liu Signed-off-by: Andreas Rheinhardt --- libavformat/dashdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index f81b323d96..d84da16dbd 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@ -627,7 +627,7 @@ static int parse_manifest_segmenturlnode(AVFormatContext *s, struct representati initialization_val); if (!rep->init_section->url) { - av_free(rep->init_section); + av_freep(&rep->init_section); xmlFree(initialization_val); xmlFree(range_val); return AVERROR(ENOMEM);