2017-07-15 16:42:33 +00:00
|
|
|
/*
|
|
|
|
* Copyright (c) 2017 Ronald S. Bultje <rsbultje@gmail.com>
|
|
|
|
* Copyright (c) 2017 Ashish Pratap Singh <ashk43712@gmail.com>
|
|
|
|
*
|
|
|
|
* This file is part of FFmpeg.
|
|
|
|
*
|
|
|
|
* FFmpeg is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* FFmpeg is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with FFmpeg; if not, write to the Free Software
|
|
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
|
|
*/
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @file
|
|
|
|
* Calculate the VMAF between two input videos.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <libvmaf.h>
|
2021-12-24 20:43:50 +00:00
|
|
|
|
2017-07-15 16:42:33 +00:00
|
|
|
#include "libavutil/avstring.h"
|
|
|
|
#include "libavutil/opt.h"
|
|
|
|
#include "libavutil/pixdesc.h"
|
|
|
|
#include "avfilter.h"
|
|
|
|
#include "drawutils.h"
|
|
|
|
#include "formats.h"
|
2017-08-31 17:47:37 +00:00
|
|
|
#include "framesync.h"
|
2017-07-15 16:42:33 +00:00
|
|
|
#include "internal.h"
|
|
|
|
#include "video.h"
|
|
|
|
|
|
|
|
typedef struct LIBVMAFContext {
|
|
|
|
const AVClass *class;
|
lavfi/vf_libvmaf: convert to framesync2.
After this commit, the code compiles, but on my setup it
segfaults before and after. It also prints the very worrying
warning:
src/libavfilter/vf_libvmaf.c:161:66: warning: passing argument 4 of ‘compute_vmaf’ from incompatible pointer type [-Wincompatible-pointer-types]
/tmp/i/include/libvmaf.h:26:8: note: expected ‘int (*)(float *, float *, float *, int, void *)’ but argument is of type ‘int (*)(float *, float *, float *, int, double *, void *)’
==12116== Thread 6:
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Use of uninitialised value of size 8
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Invalid read of size 4
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116== Address 0x40 is not stack'd, malloc'd or (recently) free'd
==12116==
==12116==
==12116== Process terminating with default action of signal 11 (SIGSEGV)
==12116== Access not within mapped region at address 0x40
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
2017-07-31 09:40:25 +00:00
|
|
|
FFFrameSync fs;
|
2017-07-15 16:42:33 +00:00
|
|
|
char *model_path;
|
|
|
|
char *log_path;
|
|
|
|
char *log_fmt;
|
|
|
|
int enable_transform;
|
|
|
|
int phone_model;
|
|
|
|
int psnr;
|
|
|
|
int ssim;
|
|
|
|
int ms_ssim;
|
|
|
|
char *pool;
|
2018-08-07 22:05:16 +00:00
|
|
|
int n_threads;
|
|
|
|
int n_subsample;
|
|
|
|
int enable_conf_interval;
|
2021-12-24 20:43:50 +00:00
|
|
|
char *model_cfg;
|
|
|
|
char *feature_cfg;
|
|
|
|
VmafContext *vmaf;
|
|
|
|
VmafModel **model;
|
|
|
|
unsigned model_cnt;
|
|
|
|
unsigned frame_cnt;
|
|
|
|
unsigned bpc;
|
2017-07-15 16:42:33 +00:00
|
|
|
} LIBVMAFContext;
|
|
|
|
|
|
|
|
#define OFFSET(x) offsetof(LIBVMAFContext, x)
|
|
|
|
#define FLAGS AV_OPT_FLAG_FILTERING_PARAM|AV_OPT_FLAG_VIDEO_PARAM
|
|
|
|
|
|
|
|
static const AVOption libvmaf_options[] = {
|
2021-12-24 20:43:50 +00:00
|
|
|
{"model_path", "use model='path=...'.", OFFSET(model_path), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS|AV_OPT_FLAG_DEPRECATED},
|
|
|
|
{"log_path", "Set the file path to be used to write log.", OFFSET(log_path), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS},
|
|
|
|
{"log_fmt", "Set the format of the log (csv, json, xml, or sub).", OFFSET(log_fmt), AV_OPT_TYPE_STRING, {.str="xml"}, 0, 1, FLAGS},
|
|
|
|
{"enable_transform", "use model='enable_transform=true'.", OFFSET(enable_transform), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS|AV_OPT_FLAG_DEPRECATED},
|
|
|
|
{"phone_model", "use model='enable_transform=true'.", OFFSET(phone_model), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS|AV_OPT_FLAG_DEPRECATED},
|
|
|
|
{"psnr", "use feature='name=psnr'.", OFFSET(psnr), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS|AV_OPT_FLAG_DEPRECATED},
|
|
|
|
{"ssim", "use feature='name=ssim'.", OFFSET(ssim), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS|AV_OPT_FLAG_DEPRECATED},
|
|
|
|
{"ms_ssim", "use feature='name=ms_ssim'.", OFFSET(ms_ssim), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS|AV_OPT_FLAG_DEPRECATED},
|
2017-07-15 16:42:33 +00:00
|
|
|
{"pool", "Set the pool method to be used for computing vmaf.", OFFSET(pool), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS},
|
2018-08-07 22:05:16 +00:00
|
|
|
{"n_threads", "Set number of threads to be used when computing vmaf.", OFFSET(n_threads), AV_OPT_TYPE_INT, {.i64=0}, 0, UINT_MAX, FLAGS},
|
|
|
|
{"n_subsample", "Set interval for frame subsampling used when computing vmaf.", OFFSET(n_subsample), AV_OPT_TYPE_INT, {.i64=1}, 1, UINT_MAX, FLAGS},
|
2021-12-24 20:43:50 +00:00
|
|
|
{"enable_conf_interval", "model='enable_conf_interval=true'.", OFFSET(enable_conf_interval), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS|AV_OPT_FLAG_DEPRECATED},
|
|
|
|
{"model", "Set the model to be used for computing vmaf.", OFFSET(model_cfg), AV_OPT_TYPE_STRING, {.str="version=vmaf_v0.6.1"}, 0, 1, FLAGS},
|
|
|
|
{"feature", "Set the feature to be used for computing vmaf.", OFFSET(feature_cfg), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS},
|
2017-07-15 16:42:33 +00:00
|
|
|
{ NULL }
|
|
|
|
};
|
|
|
|
|
lavfi/vf_libvmaf: convert to framesync2.
After this commit, the code compiles, but on my setup it
segfaults before and after. It also prints the very worrying
warning:
src/libavfilter/vf_libvmaf.c:161:66: warning: passing argument 4 of ‘compute_vmaf’ from incompatible pointer type [-Wincompatible-pointer-types]
/tmp/i/include/libvmaf.h:26:8: note: expected ‘int (*)(float *, float *, float *, int, void *)’ but argument is of type ‘int (*)(float *, float *, float *, int, double *, void *)’
==12116== Thread 6:
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Use of uninitialised value of size 8
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Invalid read of size 4
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116== Address 0x40 is not stack'd, malloc'd or (recently) free'd
==12116==
==12116==
==12116== Process terminating with default action of signal 11 (SIGSEGV)
==12116== Access not within mapped region at address 0x40
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
2017-07-31 09:40:25 +00:00
|
|
|
FRAMESYNC_DEFINE_CLASS(libvmaf, LIBVMAFContext, fs);
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
static enum VmafPixelFormat pix_fmt_map(enum AVPixelFormat av_pix_fmt)
|
|
|
|
{
|
|
|
|
switch (av_pix_fmt) {
|
|
|
|
case AV_PIX_FMT_YUV420P:
|
|
|
|
case AV_PIX_FMT_YUV420P10LE:
|
|
|
|
case AV_PIX_FMT_YUV420P12LE:
|
|
|
|
case AV_PIX_FMT_YUV420P16LE:
|
|
|
|
return VMAF_PIX_FMT_YUV420P;
|
|
|
|
case AV_PIX_FMT_YUV422P:
|
|
|
|
case AV_PIX_FMT_YUV422P10LE:
|
|
|
|
case AV_PIX_FMT_YUV422P12LE:
|
|
|
|
case AV_PIX_FMT_YUV422P16LE:
|
|
|
|
return VMAF_PIX_FMT_YUV422P;
|
|
|
|
case AV_PIX_FMT_YUV444P:
|
|
|
|
case AV_PIX_FMT_YUV444P10LE:
|
|
|
|
case AV_PIX_FMT_YUV444P12LE:
|
|
|
|
case AV_PIX_FMT_YUV444P16LE:
|
|
|
|
return VMAF_PIX_FMT_YUV444P;
|
|
|
|
default:
|
|
|
|
return VMAF_PIX_FMT_UNKNOWN;
|
|
|
|
}
|
2017-07-15 16:42:33 +00:00
|
|
|
}
|
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
static int copy_picture_data(AVFrame *src, VmafPicture *dst, unsigned bpc)
|
|
|
|
{
|
2022-09-14 16:05:50 +00:00
|
|
|
const int bytes_per_value = bpc > 8 ? 2 : 1;
|
2021-12-24 20:43:50 +00:00
|
|
|
int err = vmaf_picture_alloc(dst, pix_fmt_map(src->format), bpc,
|
|
|
|
src->width, src->height);
|
|
|
|
if (err)
|
|
|
|
return AVERROR(ENOMEM);
|
|
|
|
|
|
|
|
for (unsigned i = 0; i < 3; i++) {
|
|
|
|
uint8_t *src_data = src->data[i];
|
|
|
|
uint8_t *dst_data = dst->data[i];
|
|
|
|
for (unsigned j = 0; j < dst->h[i]; j++) {
|
2022-09-14 16:05:50 +00:00
|
|
|
memcpy(dst_data, src_data, bytes_per_value * dst->w[i]);
|
2021-12-24 20:43:50 +00:00
|
|
|
src_data += src->linesize[i];
|
|
|
|
dst_data += dst->stride[i];
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
static int do_vmaf(FFFrameSync *fs)
|
2017-07-15 16:42:33 +00:00
|
|
|
{
|
2021-12-24 20:43:50 +00:00
|
|
|
AVFilterContext *ctx = fs->parent;
|
|
|
|
LIBVMAFContext *s = ctx->priv;
|
|
|
|
VmafPicture pic_ref, pic_dist;
|
|
|
|
AVFrame *ref, *dist;
|
|
|
|
int err = 0;
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
int ret = ff_framesync_dualinput_get(fs, &dist, &ref);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
if (ctx->is_disabled || !ref)
|
|
|
|
return ff_filter_frame(ctx->outputs[0], dist);
|
|
|
|
|
|
|
|
err = copy_picture_data(ref, &pic_ref, s->bpc);
|
|
|
|
if (err) {
|
|
|
|
av_log(s, AV_LOG_ERROR, "problem during vmaf_picture_alloc.\n");
|
|
|
|
return AVERROR(ENOMEM);
|
|
|
|
}
|
|
|
|
|
|
|
|
err = copy_picture_data(dist, &pic_dist, s->bpc);
|
|
|
|
if (err) {
|
|
|
|
av_log(s, AV_LOG_ERROR, "problem during vmaf_picture_alloc.\n");
|
|
|
|
vmaf_picture_unref(&pic_ref);
|
|
|
|
return AVERROR(ENOMEM);
|
2017-07-15 16:42:33 +00:00
|
|
|
}
|
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
err = vmaf_read_pictures(s->vmaf, &pic_ref, &pic_dist, s->frame_cnt++);
|
|
|
|
if (err) {
|
|
|
|
av_log(s, AV_LOG_ERROR, "problem during vmaf_read_pictures.\n");
|
|
|
|
return AVERROR(EINVAL);
|
|
|
|
}
|
2017-11-06 12:49:19 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
return ff_filter_frame(ctx->outputs[0], dist);
|
2017-07-15 16:42:33 +00:00
|
|
|
}
|
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
|
|
|
|
static AVDictionary **delimited_dict_parse(char *str, unsigned *cnt)
|
2017-07-15 16:42:33 +00:00
|
|
|
{
|
2021-12-24 20:43:50 +00:00
|
|
|
AVDictionary **dict = NULL;
|
|
|
|
char *str_copy = NULL;
|
|
|
|
char *saveptr = NULL;
|
|
|
|
unsigned cnt2;
|
|
|
|
int err = 0;
|
|
|
|
|
|
|
|
if (!str)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
cnt2 = 1;
|
|
|
|
for (char *p = str; *p; p++) {
|
|
|
|
if (*p == '|')
|
|
|
|
cnt2++;
|
|
|
|
}
|
|
|
|
|
|
|
|
dict = av_calloc(cnt2, sizeof(*dict));
|
|
|
|
if (!dict)
|
|
|
|
goto fail;
|
|
|
|
|
|
|
|
str_copy = av_strdup(str);
|
|
|
|
if (!str_copy)
|
|
|
|
goto fail;
|
|
|
|
|
|
|
|
*cnt = 0;
|
|
|
|
for (unsigned i = 0; i < cnt2; i++) {
|
|
|
|
char *s = av_strtok(i == 0 ? str_copy : NULL, "|", &saveptr);
|
|
|
|
if (!s)
|
|
|
|
continue;
|
|
|
|
err = av_dict_parse_string(&dict[(*cnt)++], s, "=", ":", 0);
|
|
|
|
if (err)
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
av_free(str_copy);
|
|
|
|
return dict;
|
|
|
|
|
|
|
|
fail:
|
|
|
|
if (dict) {
|
|
|
|
for (unsigned i = 0; i < *cnt; i++) {
|
|
|
|
if (dict[i])
|
|
|
|
av_dict_free(&dict[i]);
|
|
|
|
}
|
|
|
|
av_free(dict);
|
2017-12-18 12:59:39 +00:00
|
|
|
}
|
2021-12-24 20:43:50 +00:00
|
|
|
|
|
|
|
av_free(str_copy);
|
|
|
|
*cnt = 0;
|
2017-12-18 12:59:39 +00:00
|
|
|
return NULL;
|
2017-07-15 16:42:33 +00:00
|
|
|
}
|
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
static int parse_features(AVFilterContext *ctx)
|
2017-07-15 16:42:33 +00:00
|
|
|
{
|
|
|
|
LIBVMAFContext *s = ctx->priv;
|
2021-12-24 20:43:50 +00:00
|
|
|
AVDictionary **dict = NULL;
|
|
|
|
unsigned dict_cnt;
|
|
|
|
int err = 0;
|
lavfi/vf_libvmaf: convert to framesync2.
After this commit, the code compiles, but on my setup it
segfaults before and after. It also prints the very worrying
warning:
src/libavfilter/vf_libvmaf.c:161:66: warning: passing argument 4 of ‘compute_vmaf’ from incompatible pointer type [-Wincompatible-pointer-types]
/tmp/i/include/libvmaf.h:26:8: note: expected ‘int (*)(float *, float *, float *, int, void *)’ but argument is of type ‘int (*)(float *, float *, float *, int, double *, void *)’
==12116== Thread 6:
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Use of uninitialised value of size 8
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Invalid read of size 4
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116== Address 0x40 is not stack'd, malloc'd or (recently) free'd
==12116==
==12116==
==12116== Process terminating with default action of signal 11 (SIGSEGV)
==12116== Access not within mapped region at address 0x40
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
2017-07-31 09:40:25 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
if (!s->feature_cfg)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
dict = delimited_dict_parse(s->feature_cfg, &dict_cnt);
|
|
|
|
if (!dict) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"could not parse feature config: %s\n", s->feature_cfg);
|
|
|
|
return AVERROR(EINVAL);
|
|
|
|
}
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
for (unsigned i = 0; i < dict_cnt; i++) {
|
|
|
|
char *feature_name = NULL;
|
|
|
|
VmafFeatureDictionary *feature_opts_dict = NULL;
|
|
|
|
AVDictionaryEntry *e = NULL;
|
|
|
|
|
|
|
|
while (e = av_dict_get(dict[i], "", e, AV_DICT_IGNORE_SUFFIX)) {
|
|
|
|
if (av_stristr(e->key, "name")) {
|
|
|
|
feature_name = e->value;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = vmaf_feature_dictionary_set(&feature_opts_dict, e->key,
|
|
|
|
e->value);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"could not set feature option: %s.%s=%s\n",
|
|
|
|
feature_name, e->key, e->value);
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
err = vmaf_use_feature(s->vmaf, feature_name, feature_opts_dict);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"problem during vmaf_use_feature: %s\n", feature_name);
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
}
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
exit:
|
|
|
|
for (unsigned i = 0; i < dict_cnt; i++) {
|
|
|
|
if (dict[i])
|
|
|
|
av_dict_free(&dict[i]);
|
2017-07-15 16:42:33 +00:00
|
|
|
}
|
2021-12-24 20:43:50 +00:00
|
|
|
av_free(dict);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int parse_models(AVFilterContext *ctx)
|
|
|
|
{
|
|
|
|
LIBVMAFContext *s = ctx->priv;
|
|
|
|
AVDictionary **dict;
|
|
|
|
unsigned dict_cnt;
|
|
|
|
int err = 0;
|
|
|
|
|
|
|
|
if (!s->model_cfg) return 0;
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
dict_cnt = 0;
|
|
|
|
dict = delimited_dict_parse(s->model_cfg, &dict_cnt);
|
|
|
|
if (!dict) {
|
2017-12-18 12:59:39 +00:00
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
2021-12-24 20:43:50 +00:00
|
|
|
"could not parse model config: %s\n", s->model_cfg);
|
2017-12-18 12:59:39 +00:00
|
|
|
return AVERROR(EINVAL);
|
|
|
|
}
|
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
s->model_cnt = dict_cnt;
|
|
|
|
s->model = av_calloc(s->model_cnt, sizeof(*s->model));
|
|
|
|
if (!s->model)
|
|
|
|
return AVERROR(ENOMEM);
|
|
|
|
|
|
|
|
for (unsigned i = 0; i < dict_cnt; i++) {
|
|
|
|
VmafModelConfig model_cfg = { 0 };
|
|
|
|
AVDictionaryEntry *e = NULL;
|
|
|
|
char *version = NULL;
|
|
|
|
char *path = NULL;
|
|
|
|
|
|
|
|
while (e = av_dict_get(dict[i], "", e, AV_DICT_IGNORE_SUFFIX)) {
|
|
|
|
if (av_stristr(e->key, "disable_clip")) {
|
|
|
|
model_cfg.flags |= av_stristr(e->value, "true") ?
|
|
|
|
VMAF_MODEL_FLAG_DISABLE_CLIP : 0;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (av_stristr(e->key, "enable_transform")) {
|
|
|
|
model_cfg.flags |= av_stristr(e->value, "true") ?
|
|
|
|
VMAF_MODEL_FLAG_ENABLE_TRANSFORM : 0;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (av_stristr(e->key, "name")) {
|
|
|
|
model_cfg.name = e->value;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (av_stristr(e->key, "version")) {
|
|
|
|
version = e->value;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (av_stristr(e->key, "path")) {
|
|
|
|
path = e->value;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (version) {
|
|
|
|
err = vmaf_model_load(&s->model[i], &model_cfg, version);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"could not load libvmaf model with version: %s\n",
|
|
|
|
version);
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (path && !s->model[i]) {
|
|
|
|
err = vmaf_model_load_from_path(&s->model[i], &model_cfg, path);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"could not load libvmaf model with path: %s\n",
|
|
|
|
path);
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!s->model[i]) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"could not load libvmaf model with config: %s\n",
|
|
|
|
s->model_cfg);
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
|
|
|
|
while (e = av_dict_get(dict[i], "", e, AV_DICT_IGNORE_SUFFIX)) {
|
|
|
|
VmafFeatureDictionary *feature_opts_dict = NULL;
|
|
|
|
char *feature_opt = NULL;
|
|
|
|
|
|
|
|
char *feature_name = av_strtok(e->key, ".", &feature_opt);
|
|
|
|
if (!feature_opt)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
err = vmaf_feature_dictionary_set(&feature_opts_dict,
|
|
|
|
feature_opt, e->value);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"could not set feature option: %s.%s=%s\n",
|
|
|
|
feature_name, feature_opt, e->value);
|
|
|
|
err = AVERROR(EINVAL);
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = vmaf_model_feature_overload(s->model[i], feature_name,
|
|
|
|
feature_opts_dict);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"could not overload feature: %s\n", feature_name);
|
|
|
|
err = AVERROR(EINVAL);
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
for (unsigned i = 0; i < s->model_cnt; i++) {
|
|
|
|
err = vmaf_use_features_from_model(s->vmaf, s->model[i]);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"problem during vmaf_use_features_from_model\n");
|
|
|
|
err = AVERROR(EINVAL);
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
exit:
|
|
|
|
for (unsigned i = 0; i < dict_cnt; i++) {
|
|
|
|
if (dict[i])
|
|
|
|
av_dict_free(&dict[i]);
|
|
|
|
}
|
|
|
|
av_free(dict);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static enum VmafLogLevel log_level_map(int log_level)
|
|
|
|
{
|
|
|
|
switch (log_level) {
|
|
|
|
case AV_LOG_QUIET:
|
|
|
|
return VMAF_LOG_LEVEL_NONE;
|
|
|
|
case AV_LOG_ERROR:
|
|
|
|
return VMAF_LOG_LEVEL_ERROR;
|
|
|
|
case AV_LOG_WARNING:
|
|
|
|
return VMAF_LOG_LEVEL_WARNING;
|
|
|
|
case AV_LOG_INFO:
|
|
|
|
return VMAF_LOG_LEVEL_INFO;
|
|
|
|
case AV_LOG_DEBUG:
|
|
|
|
return VMAF_LOG_LEVEL_DEBUG;
|
|
|
|
default:
|
|
|
|
return VMAF_LOG_LEVEL_INFO;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int parse_deprecated_options(AVFilterContext *ctx)
|
|
|
|
{
|
|
|
|
LIBVMAFContext *s = ctx->priv;
|
|
|
|
VmafModel *model = NULL;
|
|
|
|
VmafModelCollection *model_collection = NULL;
|
|
|
|
enum VmafModelFlags flags = VMAF_MODEL_FLAGS_DEFAULT;
|
|
|
|
int err = 0;
|
|
|
|
|
|
|
|
VmafModelConfig model_cfg = {
|
|
|
|
.name = "vmaf",
|
|
|
|
.flags = flags,
|
|
|
|
};
|
|
|
|
|
|
|
|
if (s->enable_transform || s->phone_model)
|
|
|
|
flags |= VMAF_MODEL_FLAG_ENABLE_TRANSFORM;
|
|
|
|
|
|
|
|
if (!s->model_path)
|
|
|
|
goto extra_metrics_only;
|
|
|
|
|
|
|
|
if (s->enable_conf_interval) {
|
|
|
|
err = vmaf_model_collection_load_from_path(&model, &model_collection,
|
|
|
|
&model_cfg, s->model_path);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"problem loading model file: %s\n", s->model_path);
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = vmaf_use_features_from_model_collection(s->vmaf, model_collection);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"problem loading feature extractors from model file: %s\n",
|
|
|
|
s->model_path);
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
err = vmaf_model_load_from_path(&model, &model_cfg, s->model_path);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"problem loading model file: %s\n", s->model_path);
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
err = vmaf_use_features_from_model(s->vmaf, model);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"problem loading feature extractors from model file: %s\n",
|
|
|
|
s->model_path);
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
extra_metrics_only:
|
|
|
|
if (s->psnr) {
|
|
|
|
VmafFeatureDictionary *d = NULL;
|
|
|
|
vmaf_feature_dictionary_set(&d, "enable_chroma", "false");
|
|
|
|
|
|
|
|
err = vmaf_use_feature(s->vmaf, "psnr", d);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"problem loading feature extractor: psnr\n");
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
}
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
if (s->ssim) {
|
|
|
|
err = vmaf_use_feature(s->vmaf, "float_ssim", NULL);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"problem loading feature extractor: ssim\n");
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
}
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
if (s->ms_ssim) {
|
|
|
|
err = vmaf_use_feature(s->vmaf, "float_ms_ssim", NULL);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"problem loading feature extractor: ms_ssim\n");
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
}
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
exit:
|
|
|
|
return err;
|
2017-07-15 16:42:33 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static av_cold int init(AVFilterContext *ctx)
|
|
|
|
{
|
|
|
|
LIBVMAFContext *s = ctx->priv;
|
2021-12-24 20:43:50 +00:00
|
|
|
int err = 0;
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
VmafConfiguration cfg = {
|
|
|
|
.log_level = log_level_map(av_log_get_level()),
|
|
|
|
.n_subsample = s->n_subsample,
|
|
|
|
.n_threads = s->n_threads,
|
|
|
|
};
|
|
|
|
|
|
|
|
err = vmaf_init(&s->vmaf, cfg);
|
|
|
|
if (err)
|
|
|
|
return AVERROR(EINVAL);
|
|
|
|
|
|
|
|
err = parse_deprecated_options(ctx);
|
|
|
|
if (err)
|
|
|
|
return err;
|
2019-11-20 15:24:22 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
err = parse_models(ctx);
|
|
|
|
if (err)
|
|
|
|
return err;
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
err = parse_features(ctx);
|
|
|
|
if (err)
|
|
|
|
return err;
|
2017-07-15 16:42:33 +00:00
|
|
|
|
lavfi/vf_libvmaf: convert to framesync2.
After this commit, the code compiles, but on my setup it
segfaults before and after. It also prints the very worrying
warning:
src/libavfilter/vf_libvmaf.c:161:66: warning: passing argument 4 of ‘compute_vmaf’ from incompatible pointer type [-Wincompatible-pointer-types]
/tmp/i/include/libvmaf.h:26:8: note: expected ‘int (*)(float *, float *, float *, int, void *)’ but argument is of type ‘int (*)(float *, float *, float *, int, double *, void *)’
==12116== Thread 6:
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Use of uninitialised value of size 8
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Invalid read of size 4
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116== Address 0x40 is not stack'd, malloc'd or (recently) free'd
==12116==
==12116==
==12116== Process terminating with default action of signal 11 (SIGSEGV)
==12116== Access not within mapped region at address 0x40
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
2017-07-31 09:40:25 +00:00
|
|
|
s->fs.on_event = do_vmaf;
|
2017-07-15 16:42:33 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2021-09-29 13:57:43 +00:00
|
|
|
static const enum AVPixelFormat pix_fmts[] = {
|
|
|
|
AV_PIX_FMT_YUV444P, AV_PIX_FMT_YUV422P, AV_PIX_FMT_YUV420P,
|
|
|
|
AV_PIX_FMT_YUV444P10LE, AV_PIX_FMT_YUV422P10LE, AV_PIX_FMT_YUV420P10LE,
|
|
|
|
AV_PIX_FMT_NONE
|
|
|
|
};
|
2017-07-15 16:42:33 +00:00
|
|
|
|
|
|
|
static int config_input_ref(AVFilterLink *inlink)
|
|
|
|
{
|
2021-12-24 20:43:50 +00:00
|
|
|
AVFilterContext *ctx = inlink->dst;
|
2017-07-15 16:42:33 +00:00
|
|
|
LIBVMAFContext *s = ctx->priv;
|
2021-12-24 20:43:50 +00:00
|
|
|
const AVPixFmtDescriptor *desc;
|
|
|
|
int err = 0;
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
if (ctx->inputs[0]->w != ctx->inputs[1]->w) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR, "input width must match.\n");
|
|
|
|
err |= AVERROR(EINVAL);
|
2017-07-15 16:42:33 +00:00
|
|
|
}
|
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
if (ctx->inputs[0]->h != ctx->inputs[1]->h) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR, "input height must match.\n");
|
|
|
|
err |= AVERROR(EINVAL);
|
|
|
|
}
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
if (ctx->inputs[0]->format != ctx->inputs[1]->format) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR, "input pix_fmt must match.\n");
|
|
|
|
err |= AVERROR(EINVAL);
|
2017-07-15 16:42:33 +00:00
|
|
|
}
|
2021-12-24 20:43:50 +00:00
|
|
|
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
desc = av_pix_fmt_desc_get(inlink->format);
|
|
|
|
s->bpc = desc->comp[0].depth;
|
2017-07-15 16:42:33 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int config_output(AVFilterLink *outlink)
|
|
|
|
{
|
|
|
|
AVFilterContext *ctx = outlink->src;
|
|
|
|
LIBVMAFContext *s = ctx->priv;
|
|
|
|
AVFilterLink *mainlink = ctx->inputs[0];
|
|
|
|
int ret;
|
|
|
|
|
2017-08-31 17:47:37 +00:00
|
|
|
ret = ff_framesync_init_dualinput(&s->fs, ctx);
|
lavfi/vf_libvmaf: convert to framesync2.
After this commit, the code compiles, but on my setup it
segfaults before and after. It also prints the very worrying
warning:
src/libavfilter/vf_libvmaf.c:161:66: warning: passing argument 4 of ‘compute_vmaf’ from incompatible pointer type [-Wincompatible-pointer-types]
/tmp/i/include/libvmaf.h:26:8: note: expected ‘int (*)(float *, float *, float *, int, void *)’ but argument is of type ‘int (*)(float *, float *, float *, int, double *, void *)’
==12116== Thread 6:
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Use of uninitialised value of size 8
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Invalid read of size 4
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116== Address 0x40 is not stack'd, malloc'd or (recently) free'd
==12116==
==12116==
==12116== Process terminating with default action of signal 11 (SIGSEGV)
==12116== Access not within mapped region at address 0x40
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
2017-07-31 09:40:25 +00:00
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
2017-07-15 16:42:33 +00:00
|
|
|
outlink->w = mainlink->w;
|
|
|
|
outlink->h = mainlink->h;
|
|
|
|
outlink->time_base = mainlink->time_base;
|
|
|
|
outlink->sample_aspect_ratio = mainlink->sample_aspect_ratio;
|
|
|
|
outlink->frame_rate = mainlink->frame_rate;
|
2017-08-31 17:47:37 +00:00
|
|
|
if ((ret = ff_framesync_configure(&s->fs)) < 0)
|
2017-07-15 16:42:33 +00:00
|
|
|
return ret;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
lavfi/vf_libvmaf: convert to framesync2.
After this commit, the code compiles, but on my setup it
segfaults before and after. It also prints the very worrying
warning:
src/libavfilter/vf_libvmaf.c:161:66: warning: passing argument 4 of ‘compute_vmaf’ from incompatible pointer type [-Wincompatible-pointer-types]
/tmp/i/include/libvmaf.h:26:8: note: expected ‘int (*)(float *, float *, float *, int, void *)’ but argument is of type ‘int (*)(float *, float *, float *, int, double *, void *)’
==12116== Thread 6:
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Use of uninitialised value of size 8
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Invalid read of size 4
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116== Address 0x40 is not stack'd, malloc'd or (recently) free'd
==12116==
==12116==
==12116== Process terminating with default action of signal 11 (SIGSEGV)
==12116== Access not within mapped region at address 0x40
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
2017-07-31 09:40:25 +00:00
|
|
|
static int activate(AVFilterContext *ctx)
|
2017-07-15 16:42:33 +00:00
|
|
|
{
|
lavfi/vf_libvmaf: convert to framesync2.
After this commit, the code compiles, but on my setup it
segfaults before and after. It also prints the very worrying
warning:
src/libavfilter/vf_libvmaf.c:161:66: warning: passing argument 4 of ‘compute_vmaf’ from incompatible pointer type [-Wincompatible-pointer-types]
/tmp/i/include/libvmaf.h:26:8: note: expected ‘int (*)(float *, float *, float *, int, void *)’ but argument is of type ‘int (*)(float *, float *, float *, int, double *, void *)’
==12116== Thread 6:
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Use of uninitialised value of size 8
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Invalid read of size 4
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116== Address 0x40 is not stack'd, malloc'd or (recently) free'd
==12116==
==12116==
==12116== Process terminating with default action of signal 11 (SIGSEGV)
==12116== Access not within mapped region at address 0x40
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
2017-07-31 09:40:25 +00:00
|
|
|
LIBVMAFContext *s = ctx->priv;
|
2017-08-31 17:47:37 +00:00
|
|
|
return ff_framesync_activate(&s->fs);
|
2017-07-15 16:42:33 +00:00
|
|
|
}
|
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
static enum VmafOutputFormat log_fmt_map(const char *log_fmt)
|
|
|
|
{
|
|
|
|
if (log_fmt) {
|
|
|
|
if (av_stristr(log_fmt, "xml"))
|
|
|
|
return VMAF_OUTPUT_FORMAT_XML;
|
|
|
|
if (av_stristr(log_fmt, "json"))
|
|
|
|
return VMAF_OUTPUT_FORMAT_JSON;
|
|
|
|
if (av_stristr(log_fmt, "csv"))
|
|
|
|
return VMAF_OUTPUT_FORMAT_CSV;
|
|
|
|
if (av_stristr(log_fmt, "sub"))
|
|
|
|
return VMAF_OUTPUT_FORMAT_SUB;
|
|
|
|
}
|
|
|
|
|
|
|
|
return VMAF_OUTPUT_FORMAT_XML;
|
|
|
|
}
|
|
|
|
|
|
|
|
static enum VmafPoolingMethod pool_method_map(const char *pool_method)
|
|
|
|
{
|
|
|
|
if (pool_method) {
|
|
|
|
if (av_stristr(pool_method, "min"))
|
|
|
|
return VMAF_POOL_METHOD_MIN;
|
|
|
|
if (av_stristr(pool_method, "mean"))
|
|
|
|
return VMAF_POOL_METHOD_MEAN;
|
|
|
|
if (av_stristr(pool_method, "harmonic_mean"))
|
|
|
|
return VMAF_POOL_METHOD_HARMONIC_MEAN;
|
|
|
|
}
|
|
|
|
|
|
|
|
return VMAF_POOL_METHOD_MEAN;
|
|
|
|
}
|
|
|
|
|
2017-07-15 16:42:33 +00:00
|
|
|
static av_cold void uninit(AVFilterContext *ctx)
|
|
|
|
{
|
|
|
|
LIBVMAFContext *s = ctx->priv;
|
2021-12-24 20:43:50 +00:00
|
|
|
int err = 0;
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2017-08-31 17:47:37 +00:00
|
|
|
ff_framesync_uninit(&s->fs);
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
if (!s->frame_cnt)
|
|
|
|
goto clean_up;
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
err = vmaf_read_pictures(s->vmaf, NULL, NULL, 0);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"problem flushing libvmaf context.\n");
|
2018-04-30 15:33:51 +00:00
|
|
|
}
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
for (unsigned i = 0; i < s->model_cnt; i++) {
|
|
|
|
double vmaf_score;
|
|
|
|
err = vmaf_score_pooled(s->vmaf, s->model[i], pool_method_map(s->pool),
|
|
|
|
&vmaf_score, 0, s->frame_cnt - 1);
|
|
|
|
if (err) {
|
|
|
|
av_log(ctx, AV_LOG_ERROR,
|
|
|
|
"problem getting pooled vmaf score.\n");
|
|
|
|
}
|
|
|
|
|
|
|
|
av_log(ctx, AV_LOG_INFO, "VMAF score: %f\n", vmaf_score);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (s->vmaf) {
|
|
|
|
if (s->log_path && !err)
|
|
|
|
vmaf_write_output(s->vmaf, s->log_path, log_fmt_map(s->log_fmt));
|
|
|
|
}
|
|
|
|
|
|
|
|
clean_up:
|
|
|
|
if (s->model) {
|
|
|
|
for (unsigned i = 0; i < s->model_cnt; i++) {
|
|
|
|
if (s->model[i])
|
|
|
|
vmaf_model_destroy(s->model[i]);
|
|
|
|
}
|
|
|
|
av_free(s->model);
|
|
|
|
}
|
2017-07-15 16:42:33 +00:00
|
|
|
|
2021-12-24 20:43:50 +00:00
|
|
|
if (s->vmaf)
|
|
|
|
vmaf_close(s->vmaf);
|
2017-07-15 16:42:33 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static const AVFilterPad libvmaf_inputs[] = {
|
|
|
|
{
|
|
|
|
.name = "main",
|
|
|
|
.type = AVMEDIA_TYPE_VIDEO,
|
|
|
|
},{
|
|
|
|
.name = "reference",
|
|
|
|
.type = AVMEDIA_TYPE_VIDEO,
|
|
|
|
.config_props = config_input_ref,
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
|
|
|
static const AVFilterPad libvmaf_outputs[] = {
|
|
|
|
{
|
|
|
|
.name = "default",
|
|
|
|
.type = AVMEDIA_TYPE_VIDEO,
|
|
|
|
.config_props = config_output,
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
2021-04-19 16:33:56 +00:00
|
|
|
const AVFilter ff_vf_libvmaf = {
|
2017-07-15 16:42:33 +00:00
|
|
|
.name = "libvmaf",
|
|
|
|
.description = NULL_IF_CONFIG_SMALL("Calculate the VMAF between two video streams."),
|
lavfi/vf_libvmaf: convert to framesync2.
After this commit, the code compiles, but on my setup it
segfaults before and after. It also prints the very worrying
warning:
src/libavfilter/vf_libvmaf.c:161:66: warning: passing argument 4 of ‘compute_vmaf’ from incompatible pointer type [-Wincompatible-pointer-types]
/tmp/i/include/libvmaf.h:26:8: note: expected ‘int (*)(float *, float *, float *, int, void *)’ but argument is of type ‘int (*)(float *, float *, float *, int, double *, void *)’
==12116== Thread 6:
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Use of uninitialised value of size 8
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Invalid read of size 4
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116== Address 0x40 is not stack'd, malloc'd or (recently) free'd
==12116==
==12116==
==12116== Process terminating with default action of signal 11 (SIGSEGV)
==12116== Access not within mapped region at address 0x40
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
2017-07-31 09:40:25 +00:00
|
|
|
.preinit = libvmaf_framesync_preinit,
|
2017-07-15 16:42:33 +00:00
|
|
|
.init = init,
|
|
|
|
.uninit = uninit,
|
lavfi/vf_libvmaf: convert to framesync2.
After this commit, the code compiles, but on my setup it
segfaults before and after. It also prints the very worrying
warning:
src/libavfilter/vf_libvmaf.c:161:66: warning: passing argument 4 of ‘compute_vmaf’ from incompatible pointer type [-Wincompatible-pointer-types]
/tmp/i/include/libvmaf.h:26:8: note: expected ‘int (*)(float *, float *, float *, int, void *)’ but argument is of type ‘int (*)(float *, float *, float *, int, double *, void *)’
==12116== Thread 6:
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Conditional jump or move depends on uninitialised value(s)
==12116== at 0x526D432: cons_ (ocval.h:1188)
==12116== by 0x526D432: GenericIT (ocval.h:1119)
==12116== by 0x526D432: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:92)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x526D50D: OC::TranslateForNumPyClassesToArray(OC::Val&) (pickleloader.h:94)
==12116== by 0x5211F5D: loads (pickleloader.h:566)
==12116== by 0x5211F5D: LoadValFromArray (chooseser.h:290)
==12116== by 0x5211F5D: LoadValFromFile (chooseser.h:405)
==12116== by 0x5211F5D: _read_and_assert_model(char const*, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&, OC::Val&) (vmaf.cpp:77)
==12116== by 0x5212B0F: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:149)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Use of uninitialised value of size 8
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116==
==12116== Invalid read of size 4
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
==12116== Address 0x40 is not stack'd, malloc'd or (recently) free'd
==12116==
==12116==
==12116== Process terminating with default action of signal 11 (SIGSEGV)
==12116== Access not within mapped region at address 0x40
==12116== at 0x518AC79: read_frame_8bit (vf_libvmaf.c:147)
==12116== by 0x52AB5E8: combo (combo.c:149)
==12116== by 0x5212E95: VmafRunner::run(Asset, int (*)(float*, float*, float*, int, void*), void*, bool, bool, bool, bool, bool) (vmaf.cpp:278)
==12116== by 0x52165B6: RunVmaf(char const*, int, int, int (*)(float*, float*, float*, int, void*), void*, char const*, char const*, char const*, bool, bool, bool, bool, bool, char const*) (vmaf.cpp:645)
==12116== by 0x518AFFF: compute_vmaf_score (vf_libvmaf.c:161)
==12116== by 0x518AFFF: call_vmaf (vf_libvmaf.c:170)
==12116== by 0x7967493: start_thread (pthread_create.c:333)
==12116== by 0x7F69A8E: clone (clone.S:97)
2017-07-31 09:40:25 +00:00
|
|
|
.activate = activate,
|
2017-07-15 16:42:33 +00:00
|
|
|
.priv_size = sizeof(LIBVMAFContext),
|
|
|
|
.priv_class = &libvmaf_class,
|
2021-08-12 11:05:31 +00:00
|
|
|
FILTER_INPUTS(libvmaf_inputs),
|
|
|
|
FILTER_OUTPUTS(libvmaf_outputs),
|
2021-09-27 19:40:31 +00:00
|
|
|
FILTER_PIXFMTS_ARRAY(pix_fmts),
|
2017-07-15 16:42:33 +00:00
|
|
|
};
|