From fa204f85578296135d19987b55ddeb6622ff68a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Piotrowski?= Date: Fri, 5 Dec 2014 19:37:06 +0100 Subject: [PATCH] abuild: remove *.la files by default Libtool archives are useless in the most of cases and can be safely removed. A quick grep shows that *.la files are explicitly removed in 903 APKBUILDs, while intentionally preserved only in 17. postcheck() is discussable place to perform the deletion, but it's currently the only function being run for each subpackage, including the artifact of package(). --- abuild.in | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/abuild.in b/abuild.in index 5459a9b..1ccb1e4 100644 --- a/abuild.in +++ b/abuild.in @@ -616,13 +616,12 @@ postcheck() { return 1 fi fi - # look for *.la files - i=$(find "$dir" -name '*.la' | sed "s|^$dir|\t|") - if [ -n "$i" ] && ! options_has "libtool"; then - error "Libtool archives (*.la) files found and \$options has no 'libtool' flag:" - echo "$i" - return 1 + + # remove *.la files if libtool is not set + if ! options_has "libtool"; then + find "$dir" -name '*.la' -type f -delete fi + # look for /usr/lib/charset.alias if [ -e "$dir"/usr/lib/charset.alias ] \ && ! options_has "charset.alias"; then